-
-
Notifications
You must be signed in to change notification settings - Fork 713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
comparingOnlyFields
gives false positive on Iterable
objects
#3129
Comments
I was able to replicate the behavior on tags/assertj-build-3.24.2 where both of the below pass.
But the first one is working correctly on main and so I believe it has already been fixed. I"d like to pick this issue up if the assertj team see the benefit in it? |
Thanks for checking on main @aindriu-aiven, I agree that the recursive comparison should fail if |
Thanks @joel-costigliola I"ll pick it up! |
@joel-costigliola |
Integrated thanks @aindriu-aiven ! |
comparingOnlyFields
gives false positive on Iterable
objects
Describe the bug
When
comparingOnlyFields()
is used on a list of objects to recursively compare object properties it never reports a failure.I would have expected it to behave like a complement to
ignoringFields()
(which works as expected on a list of objects).Test case reproducing the bug
The text was updated successfully, but these errors were encountered: