{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":376383688,"defaultBranch":"main","name":"aspect-cli","ownerLogin":"aspect-build","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2021-06-12T21:05:04.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/60951090?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1723075087.0","currentOid":""},"activityList":{"items":[{"before":"2d6d8cbd15bc10e4e97696fc5193fbe0b4bef97d","after":null,"ref":"refs/tags/v.505.4","pushedAt":"2024-08-07T23:57:49.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"gregmagolan","name":"Greg Magolan","path":"/gregmagolan","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/520826?s=80&v=4"}},{"before":"061659572e2b4d9f9bf6f560e9b4776491deb09a","after":null,"ref":"refs/tags/5.10.14","pushedAt":"2024-08-07T23:57:42.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"gregmagolan","name":"Greg Magolan","path":"/gregmagolan","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/520826?s=80&v=4"}},{"before":"061659572e2b4d9f9bf6f560e9b4776491deb09a","after":null,"ref":"refs/tags/rm","pushedAt":"2024-08-07T18:18:05.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"jbedard","name":"Jason Bedard","path":"/jbedard","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/89246?s=80&v=4"}},{"before":"f440e3210646a564fff814c517723bb4ddf30403","after":null,"ref":"refs/heads/788EA150BB0FAAB4A3FF81F26DCBE189","pushedAt":"2024-08-07T17:12:57.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"alexeagle","name":"Alex Eagle","path":"/alexeagle","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/47395?s=80&v=4"}},{"before":"198a1e70b0b0938249bb41637cb631dbf0fe511f","after":"061659572e2b4d9f9bf6f560e9b4776491deb09a","ref":"refs/heads/main","pushedAt":"2024-08-07T17:12:55.000Z","pushType":"pr_merge","commitsCount":16,"pusher":{"login":"alexeagle","name":"Alex Eagle","path":"/alexeagle","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/47395?s=80&v=4"},"commit":{"message":"chore(*): upgrade go mod deps","shortMessageHtmlLink":"chore(*): upgrade go mod deps"}},{"before":"b13f2394fcdb41d6a4b6900300e92f9e1043eb87","after":"f440e3210646a564fff814c517723bb4ddf30403","ref":"refs/heads/788EA150BB0FAAB4A3FF81F26DCBE189","pushedAt":"2024-08-07T06:02:32.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"jbedard","name":"Jason Bedard","path":"/jbedard","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/89246?s=80&v=4"},"commit":{"message":"chore(*): upgrade go mod deps","shortMessageHtmlLink":"chore(*): upgrade go mod deps"}},{"before":"db364eb62d3194d30c3defb094c2d6c6069db5be","after":null,"ref":"refs/heads/D5E6C3085CF669C3102897C2089A5B5C","pushedAt":"2024-08-07T05:56:22.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"jbedard","name":"Jason Bedard","path":"/jbedard","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/89246?s=80&v=4"}},{"before":"03ad8add5be7ff727e3488e8d8e118cd63b82bd4","after":"b13f2394fcdb41d6a4b6900300e92f9e1043eb87","ref":"refs/heads/788EA150BB0FAAB4A3FF81F26DCBE189","pushedAt":"2024-08-07T05:30:59.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"jbedard","name":"Jason Bedard","path":"/jbedard","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/89246?s=80&v=4"},"commit":{"message":"fix(cli): relativize paths before applying lint fixes (#6281)\n\nThe paths we get from our gitdiff handling are always\nworkspace-relative, so we can't rely on them being cwd-relative.\n\nFixes https://github.com/aspect-build/aspect-cli/issues/672\n\n---\n\n### Changes are visible to end-users: no\n\n### Test plan\n\n- Manual testing; please provide instructions so we can reproduce:\n\nIn `rules_lint/example/src`, ran\n\n```\n % ~/Projects/silo/bazel-bin/cli/core/cmd/aspect/aspect_/aspect lint --fix :css\nINFO: Analyzed target //src:css (0 packages loaded, 0 targets configured).\nINFO: Found 1 target...\nAspect //tools/lint:linters.bzl%stylelint of //src:css up-to-date:\n  bazel-bin/src/css.AspectRulesLintStylelint.patch\n  bazel-bin/src/css.AspectRulesLintStylelint.report\n  bazel-bin/src/css.AspectRulesLintStylelint.report.exit_code\nINFO: Elapsed time: 0.170s, Critical Path: 0.00s\nINFO: 1 process: 1 internal.\nINFO: Build completed successfully, 1 total action\nLint results for //src:css:\n\n/private/var/tmp/_bazel_alexeagle/3eecd93732ac7c6f4f360a54a468da50/sandbox/darwin-sandbox/115/execroot/_main/bazel-out/darwin_arm64-fastbuild/bin/src/hello.css: line 11, col 5, error - Unexpected empty block (block-no-empty)\n/private/var/tmp/_bazel_alexeagle/3eecd93732ac7c6f4f360a54a468da50/sandbox/darwin-sandbox/115/execroot/_main/bazel-out/darwin_arm64-fastbuild/bin/src/hello.css: line 16, col 3, error - Unexpected duplicate \"color\" (declaration-block-no-duplicate-properties)\n\nSome problems have automated fixes available:\n\n  src/hello.css | 1 -\n  1 file, 1 deletion(-)\n\nPatched src/hello.css\n```\n\nGitOrigin-RevId: 72a798fba7b991e7d89af2fc5c94bebc936913dc","shortMessageHtmlLink":"fix(cli): relativize paths before applying lint fixes (#6281)"}},{"before":"de3c6ec59c777e963ae505c0fb6eac5d0e591ba3","after":"03ad8add5be7ff727e3488e8d8e118cd63b82bd4","ref":"refs/heads/788EA150BB0FAAB4A3FF81F26DCBE189","pushedAt":"2024-08-07T05:14:00.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"jbedard","name":"Jason Bedard","path":"/jbedard","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/89246?s=80&v=4"},"commit":{"message":"fix(cli): relativize paths before applying lint fixes (#6281)\n\nThe paths we get from our gitdiff handling are always\nworkspace-relative, so we can't rely on them being cwd-relative.\n\nFixes https://github.com/aspect-build/aspect-cli/issues/672\n\n---\n\n### Changes are visible to end-users: no\n\n### Test plan\n\n- Manual testing; please provide instructions so we can reproduce:\n\nIn `rules_lint/example/src`, ran\n\n```\n % ~/Projects/silo/bazel-bin/cli/core/cmd/aspect/aspect_/aspect lint --fix :css\nINFO: Analyzed target //src:css (0 packages loaded, 0 targets configured).\nINFO: Found 1 target...\nAspect //tools/lint:linters.bzl%stylelint of //src:css up-to-date:\n  bazel-bin/src/css.AspectRulesLintStylelint.patch\n  bazel-bin/src/css.AspectRulesLintStylelint.report\n  bazel-bin/src/css.AspectRulesLintStylelint.report.exit_code\nINFO: Elapsed time: 0.170s, Critical Path: 0.00s\nINFO: 1 process: 1 internal.\nINFO: Build completed successfully, 1 total action\nLint results for //src:css:\n\n/private/var/tmp/_bazel_alexeagle/3eecd93732ac7c6f4f360a54a468da50/sandbox/darwin-sandbox/115/execroot/_main/bazel-out/darwin_arm64-fastbuild/bin/src/hello.css: line 11, col 5, error - Unexpected empty block (block-no-empty)\n/private/var/tmp/_bazel_alexeagle/3eecd93732ac7c6f4f360a54a468da50/sandbox/darwin-sandbox/115/execroot/_main/bazel-out/darwin_arm64-fastbuild/bin/src/hello.css: line 16, col 3, error - Unexpected duplicate \"color\" (declaration-block-no-duplicate-properties)\n\nSome problems have automated fixes available:\n\n  src/hello.css | 1 -\n  1 file, 1 deletion(-)\n\nPatched src/hello.css\n```\n\nGitOrigin-RevId: 72a798fba7b991e7d89af2fc5c94bebc936913dc","shortMessageHtmlLink":"fix(cli): relativize paths before applying lint fixes (#6281)"}},{"before":"d5f943ac81f9029db6d7e4d7afa3ee086a348214","after":"de3c6ec59c777e963ae505c0fb6eac5d0e591ba3","ref":"refs/heads/788EA150BB0FAAB4A3FF81F26DCBE189","pushedAt":"2024-08-07T05:12:04.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"jbedard","name":"Jason Bedard","path":"/jbedard","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/89246?s=80&v=4"},"commit":{"message":"fix(cli): relativize paths before applying lint fixes (#6281)\n\nThe paths we get from our gitdiff handling are always\nworkspace-relative, so we can't rely on them being cwd-relative.\n\nFixes https://github.com/aspect-build/aspect-cli/issues/672\n\n---\n\n### Changes are visible to end-users: no\n\n### Test plan\n\n- Manual testing; please provide instructions so we can reproduce:\n\nIn `rules_lint/example/src`, ran\n\n```\n % ~/Projects/silo/bazel-bin/cli/core/cmd/aspect/aspect_/aspect lint --fix :css\nINFO: Analyzed target //src:css (0 packages loaded, 0 targets configured).\nINFO: Found 1 target...\nAspect //tools/lint:linters.bzl%stylelint of //src:css up-to-date:\n  bazel-bin/src/css.AspectRulesLintStylelint.patch\n  bazel-bin/src/css.AspectRulesLintStylelint.report\n  bazel-bin/src/css.AspectRulesLintStylelint.report.exit_code\nINFO: Elapsed time: 0.170s, Critical Path: 0.00s\nINFO: 1 process: 1 internal.\nINFO: Build completed successfully, 1 total action\nLint results for //src:css:\n\n/private/var/tmp/_bazel_alexeagle/3eecd93732ac7c6f4f360a54a468da50/sandbox/darwin-sandbox/115/execroot/_main/bazel-out/darwin_arm64-fastbuild/bin/src/hello.css: line 11, col 5, error - Unexpected empty block (block-no-empty)\n/private/var/tmp/_bazel_alexeagle/3eecd93732ac7c6f4f360a54a468da50/sandbox/darwin-sandbox/115/execroot/_main/bazel-out/darwin_arm64-fastbuild/bin/src/hello.css: line 16, col 3, error - Unexpected duplicate \"color\" (declaration-block-no-duplicate-properties)\n\nSome problems have automated fixes available:\n\n  src/hello.css | 1 -\n  1 file, 1 deletion(-)\n\nPatched src/hello.css\n```\n\nGitOrigin-RevId: 72a798fba7b991e7d89af2fc5c94bebc936913dc","shortMessageHtmlLink":"fix(cli): relativize paths before applying lint fixes (#6281)"}},{"before":"5505c95564d15490f5336e31445c7fc8f2e6bdc9","after":"d5f943ac81f9029db6d7e4d7afa3ee086a348214","ref":"refs/heads/788EA150BB0FAAB4A3FF81F26DCBE189","pushedAt":"2024-08-07T05:06:53.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"jbedard","name":"Jason Bedard","path":"/jbedard","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/89246?s=80&v=4"},"commit":{"message":"fix(cli): relativize paths before applying lint fixes (#6281)\n\nThe paths we get from our gitdiff handling are always\nworkspace-relative, so we can't rely on them being cwd-relative.\n\nFixes https://github.com/aspect-build/aspect-cli/issues/672\n\n---\n\n### Changes are visible to end-users: no\n\n### Test plan\n\n- Manual testing; please provide instructions so we can reproduce:\n\nIn `rules_lint/example/src`, ran\n\n```\n % ~/Projects/silo/bazel-bin/cli/core/cmd/aspect/aspect_/aspect lint --fix :css\nINFO: Analyzed target //src:css (0 packages loaded, 0 targets configured).\nINFO: Found 1 target...\nAspect //tools/lint:linters.bzl%stylelint of //src:css up-to-date:\n  bazel-bin/src/css.AspectRulesLintStylelint.patch\n  bazel-bin/src/css.AspectRulesLintStylelint.report\n  bazel-bin/src/css.AspectRulesLintStylelint.report.exit_code\nINFO: Elapsed time: 0.170s, Critical Path: 0.00s\nINFO: 1 process: 1 internal.\nINFO: Build completed successfully, 1 total action\nLint results for //src:css:\n\n/private/var/tmp/_bazel_alexeagle/3eecd93732ac7c6f4f360a54a468da50/sandbox/darwin-sandbox/115/execroot/_main/bazel-out/darwin_arm64-fastbuild/bin/src/hello.css: line 11, col 5, error - Unexpected empty block (block-no-empty)\n/private/var/tmp/_bazel_alexeagle/3eecd93732ac7c6f4f360a54a468da50/sandbox/darwin-sandbox/115/execroot/_main/bazel-out/darwin_arm64-fastbuild/bin/src/hello.css: line 16, col 3, error - Unexpected duplicate \"color\" (declaration-block-no-duplicate-properties)\n\nSome problems have automated fixes available:\n\n  src/hello.css | 1 -\n  1 file, 1 deletion(-)\n\nPatched src/hello.css\n```\n\nGitOrigin-RevId: 72a798fba7b991e7d89af2fc5c94bebc936913dc","shortMessageHtmlLink":"fix(cli): relativize paths before applying lint fixes (#6281)"}},{"before":"6fec41bd3d4d8a85542b267a8b3cb7b44ac69e9b","after":"5505c95564d15490f5336e31445c7fc8f2e6bdc9","ref":"refs/heads/788EA150BB0FAAB4A3FF81F26DCBE189","pushedAt":"2024-08-06T18:56:00.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"jbedard","name":"Jason Bedard","path":"/jbedard","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/89246?s=80&v=4"},"commit":{"message":"fix(cli): relativize paths before applying lint fixes (#6281)\n\nThe paths we get from our gitdiff handling are always\nworkspace-relative, so we can't rely on them being cwd-relative.\n\nFixes https://github.com/aspect-build/aspect-cli/issues/672\n\n---\n\n### Changes are visible to end-users: no\n\n### Test plan\n\n- Manual testing; please provide instructions so we can reproduce:\n\nIn `rules_lint/example/src`, ran\n\n```\n % ~/Projects/silo/bazel-bin/cli/core/cmd/aspect/aspect_/aspect lint --fix :css\nINFO: Analyzed target //src:css (0 packages loaded, 0 targets configured).\nINFO: Found 1 target...\nAspect //tools/lint:linters.bzl%stylelint of //src:css up-to-date:\n  bazel-bin/src/css.AspectRulesLintStylelint.patch\n  bazel-bin/src/css.AspectRulesLintStylelint.report\n  bazel-bin/src/css.AspectRulesLintStylelint.report.exit_code\nINFO: Elapsed time: 0.170s, Critical Path: 0.00s\nINFO: 1 process: 1 internal.\nINFO: Build completed successfully, 1 total action\nLint results for //src:css:\n\n/private/var/tmp/_bazel_alexeagle/3eecd93732ac7c6f4f360a54a468da50/sandbox/darwin-sandbox/115/execroot/_main/bazel-out/darwin_arm64-fastbuild/bin/src/hello.css: line 11, col 5, error - Unexpected empty block (block-no-empty)\n/private/var/tmp/_bazel_alexeagle/3eecd93732ac7c6f4f360a54a468da50/sandbox/darwin-sandbox/115/execroot/_main/bazel-out/darwin_arm64-fastbuild/bin/src/hello.css: line 16, col 3, error - Unexpected duplicate \"color\" (declaration-block-no-duplicate-properties)\n\nSome problems have automated fixes available:\n\n  src/hello.css | 1 -\n  1 file, 1 deletion(-)\n\nPatched src/hello.css\n```\n\nGitOrigin-RevId: 72a798fba7b991e7d89af2fc5c94bebc936913dc","shortMessageHtmlLink":"fix(cli): relativize paths before applying lint fixes (#6281)"}},{"before":"42359cad92874e49c4ab042fe15b39927aeb69e8","after":"6fec41bd3d4d8a85542b267a8b3cb7b44ac69e9b","ref":"refs/heads/788EA150BB0FAAB4A3FF81F26DCBE189","pushedAt":"2024-08-06T18:55:55.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"jbedard","name":"Jason Bedard","path":"/jbedard","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/89246?s=80&v=4"},"commit":{"message":"feat(CLI): Add new exit code for linting failures (#6267)\n\nCreate a new aspect specific linting failure exit code. Exit using that\ncode from the CLI lint handler when there are lint failures\n\n---\n\n### Changes are visible to end-users: no\n\n### Test plan\n\n- Manual testing; please provide instructions so we can reproduce:\n\nI have created a series of lint failures to test this. Will be following\nup with tests at a later date\n\nGitOrigin-RevId: 86f5076b7e9fc32de1e7ac81cac7943b12b19f27","shortMessageHtmlLink":"feat(CLI): Add new exit code for linting failures (#6267)"}},{"before":"3f38db42885ec92745f7cc0ea3b58a822d3bcbf5","after":"42359cad92874e49c4ab042fe15b39927aeb69e8","ref":"refs/heads/788EA150BB0FAAB4A3FF81F26DCBE189","pushedAt":"2024-08-06T18:55:49.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"jbedard","name":"Jason Bedard","path":"/jbedard","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/89246?s=80&v=4"},"commit":{"message":"feat(cli): declare starzelle rule imports by attribute (#6207)\n\nThis changes target dependencies from being declared per-rule to\nper-attribute. This way a generated target can easily have multiple\nattributes that depend on other targets.\n\nThe idea of declaring one set of `Imports` per generated target comes\nfrom gazelle which was originally designed with only\n`go_{library,binary}(deps)` in mind... one set of `deps` per rule.\nHowever other rules may have multiple attributes that must be resolved\nso putting all dependencies (\"imports\") into a single array is unclear\nand not ideal.\n\n---\n\n### Changes are visible to end-users: no\n\n### Test plan\n\n- Covered by existing test cases\n- New test cases added\n\nGitOrigin-RevId: c350c412081550f755788276882c572076bc5559","shortMessageHtmlLink":"feat(cli): declare starzelle rule imports by attribute (#6207)"}},{"before":"1d0a1a1c795affd0adc06cb11b19a5b53011bbf3","after":"3f38db42885ec92745f7cc0ea3b58a822d3bcbf5","ref":"refs/heads/788EA150BB0FAAB4A3FF81F26DCBE189","pushedAt":"2024-08-06T18:55:43.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"jbedard","name":"Jason Bedard","path":"/jbedard","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/89246?s=80&v=4"},"commit":{"message":"feat(cli): add starzelle source parsing via regex, json, raw text (#6195)\n\nNon-treesitter queries for things like simple text, regex for\nmatching/filtering text, jq for matching/filtering json.\n\nWithin go the starzelle plugins just need to construct:\n```\nplugin.QueryDefinition{\n\tFilter:    \"*.x\",\n\tProcessor: func(file, queries, *results),\n\tParams:    paramsToFunc,\n}\n```\n\nNote the processor accepts a set of queries for the common case where\nthe file is parsed and then multiple queries run against the parsed\nvalue (such as an AST or parsed JSON etc).\n\nThe `Processor` fills `results[queryKey] = queryResult` with whatever\nvalue it wants, ideally something that implements `starlark.Value` so it\ncan be used by plugins written in starlark.\n\nA few builtin `Processor`s have been defined such as:\n* `raw`: simply return the full file as text\n* `json`: run a jq filter on a blob of json and return the result of\nthat filter\n* `regex`: run a regex on the file and return an array of `QueryMatch`s,\neach containing the match `result` and `captures`\n* `ast`: the existing tree-sitter API also returning an array of\n`QueryMatch`s\n\nThese can be passed as the `QueryDefinition{Processor}` for use of these\nbuiltin processors. The starlark API provides factory methods to\nconstruct these builtin query types.\n\n---\n\n### Changes are visible to end-users: no\n\n### Test plan\n\n- New test cases added\n\nGitOrigin-RevId: 111ed5a54c01d55415c94bda338fd18b287d6e3f","shortMessageHtmlLink":"feat(cli): add starzelle source parsing via regex, json, raw text (#6…"}},{"before":"f698f4e17518b41c5b8c790d9847ca9da1a1d858","after":"1d0a1a1c795affd0adc06cb11b19a5b53011bbf3","ref":"refs/heads/788EA150BB0FAAB4A3FF81F26DCBE189","pushedAt":"2024-08-06T18:55:38.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"jbedard","name":"Jason Bedard","path":"/jbedard","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/89246?s=80&v=4"},"commit":{"message":"fix(cli): support gazelle resolution of esm imports of URLs (#6262)\n\nThe go `path.Clean` breaks URLs such as changing `://` to `:/` so it\nshould only be used for what we assume to be paths. This will include\nrelative paths, absolute paths (which might be npm packages), but now\nexcludes anything with a protocol.\n\n---\n\n### Changes are visible to end-users: no\n\n### Test plan\n\n- Covered by existing test cases\n- New test cases added\n\nGitOrigin-RevId: da73e1120ff77f8d0a4a890ed6c9935276951554","shortMessageHtmlLink":"fix(cli): support gazelle resolution of esm imports of URLs (#6262)"}},{"before":"230515a76619249c735e9152e1d5e0b8d93a3d9e","after":"f698f4e17518b41c5b8c790d9847ca9da1a1d858","ref":"refs/heads/788EA150BB0FAAB4A3FF81F26DCBE189","pushedAt":"2024-08-06T18:55:32.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"jbedard","name":"Jason Bedard","path":"/jbedard","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/89246?s=80&v=4"},"commit":{"message":"fix(cli): respect js_ignore_imports for tsconfig deps (#6261)\n\nTS config files should respect the `js_ignore_imports` just like imports\nfrom .ts files.\n\nFor example sometimes tsconfig files will reference things not available\nto gazelle, or BUILD file authors may not be able to edit the tsconfig\nfile.\n\n---\n\n### Changes are visible to end-users: no\n\n### Test plan\n\n- Covered by existing test cases\n- New test cases added\n\nGitOrigin-RevId: 8548103e655c60c6dd9d2194fa3db1d65a7fef1b","shortMessageHtmlLink":"fix(cli): respect js_ignore_imports for tsconfig deps (#6261)"}},{"before":"fef4dc3beb38f59146c815b7caa23ca86b9b89e4","after":"230515a76619249c735e9152e1d5e0b8d93a3d9e","ref":"refs/heads/788EA150BB0FAAB4A3FF81F26DCBE189","pushedAt":"2024-08-06T18:55:27.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"jbedard","name":"Jason Bedard","path":"/jbedard","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/89246?s=80&v=4"},"commit":{"message":"feat(cli): add gazelle js_visibility directive (#6238)\n\nClose https://github.com/aspect-build/aspect-cli/issues/732\n\nFormat:\n```\n# gazelle:js_visibility [target] ...labels\n```\n\nThis is similar to\n[go_visibility](https://github.com/bazelbuild/bazel-gazelle#directives)\nwith a few key differences:\n* js does not have anything similar to the [go default visibility\nlogic](https://github.com/bazelbuild/bazel-gazelle/blob/v0.37.0/language/go/generate.go#L779),\nby default js does nothing (and users can provide their own defaults in\na macro)\n* `js_visibliity` is inherited by subdirs so you can have \"default\nlogic\" in a parent BUILD and don't have to repeat it\n* `js_visibility` overwrites any previous values (such as inherited\nones) instead of appending like go, if you want to append then just\nspecify multiple values when using the directive\n\n---\n\n### Changes are visible to end-users: no\n\n### Test plan\n\n- Covered by existing test cases\n- New test cases added\n\nGitOrigin-RevId: 12260503e76902f25bbf6714434e6f5ee21bc14b","shortMessageHtmlLink":"feat(cli): add gazelle js_visibility directive (#6238)"}},{"before":"9617ea099b05fe4d193517d57052c270806cc698","after":"fef4dc3beb38f59146c815b7caa23ca86b9b89e4","ref":"refs/heads/788EA150BB0FAAB4A3FF81F26DCBE189","pushedAt":"2024-08-06T18:55:21.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"jbedard","name":"Jason Bedard","path":"/jbedard","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/89246?s=80&v=4"},"commit":{"message":"feat(cli): add configure support for ts_project(allow_js) (#6221)\n\nClose https://github.com/aspect-build/aspect-cli/issues/717\n\n---\n\n### Changes are visible to end-users: no\n\n### Test plan\n\n- Covered by existing test cases\n- New test cases added\n\nGitOrigin-RevId: 7b20f1671a2a3fabc5825401bd8674947f79a1ca","shortMessageHtmlLink":"feat(cli): add configure support for ts_project(allow_js) (#6221)"}},{"before":"31e532d7cf2ba4be4c3bea5f475b4ae1a6405ed1","after":"9617ea099b05fe4d193517d57052c270806cc698","ref":"refs/heads/788EA150BB0FAAB4A3FF81F26DCBE189","pushedAt":"2024-08-06T18:55:16.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"jbedard","name":"Jason Bedard","path":"/jbedard","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/89246?s=80&v=4"},"commit":{"message":"fix(cli): do not generate tsconfig attributes on js_library targets (#6214)\n\nIf a tsconfig exists but we are generating a `js_library` (because there\nare no `.ts` files) we should not generate the`ts_project` attributes\nsuch as `tsconfig`, `root_dir`, `out_dir` etc.\n\n---\n\n### Changes are visible to end-users: no\n\n### Test plan\n\n- New test cases added\n\nGitOrigin-RevId: 949a1ddbb04dcb42921dfe615cd92ca35a5e0987","shortMessageHtmlLink":"fix(cli): do not generate tsconfig attributes on js_library targets (…"}},{"before":"41b7d111a96a26b5dda1898a7e7b6657573f0f02","after":"31e532d7cf2ba4be4c3bea5f475b4ae1a6405ed1","ref":"refs/heads/788EA150BB0FAAB4A3FF81F26DCBE189","pushedAt":"2024-08-06T18:55:10.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"jbedard","name":"Jason Bedard","path":"/jbedard","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/89246?s=80&v=4"},"commit":{"message":"fix(cli): declare react dependency when using tsconfig tsx:react (#6184)\n\nFix https://github.com/aspect-build/aspect-cli/issues/728\n\n---\n\n### Changes are visible to end-users: no\n\n### Test plan\n\n- New test cases added\n\nGitOrigin-RevId: b8fcc9426e98175177f14b8d67abdb2ee1fd6783","shortMessageHtmlLink":"fix(cli): declare react dependency when using tsconfig tsx:react (#6184)"}},{"before":"08f3deaaae34f9f96d93a89b8660ed18dd3ef93a","after":"41b7d111a96a26b5dda1898a7e7b6657573f0f02","ref":"refs/heads/788EA150BB0FAAB4A3FF81F26DCBE189","pushedAt":"2024-08-06T18:55:05.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"jbedard","name":"Jason Bedard","path":"/jbedard","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/89246?s=80&v=4"},"commit":{"message":"chore: upgrade to rules_ts 3.x (#6164)\n\n---\n\n### Changes are visible to end-users: no\n\nGitOrigin-RevId: 879668f88b0c1a44e262a4f3960a1615c199ceba","shortMessageHtmlLink":"chore: upgrade to rules_ts 3.x (#6164)"}},{"before":"57bc414f9fea72d15b3c26b7db4d1886653a1160","after":"08f3deaaae34f9f96d93a89b8660ed18dd3ef93a","ref":"refs/heads/788EA150BB0FAAB4A3FF81F26DCBE189","pushedAt":"2024-08-06T18:54:59.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"jbedard","name":"Jason Bedard","path":"/jbedard","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/89246?s=80&v=4"},"commit":{"message":"chore: ts_proto_library emits commonjs (#6134)\n\n---\n\n### Changes are visible to end-users: no\n\nGitOrigin-RevId: 4525e80cbee246850bdb2325ca202fea0d60d0a9","shortMessageHtmlLink":"chore: ts_proto_library emits commonjs (#6134)"}},{"before":"6dfe627f6e0fd049df241a7df73ae37ccedc6df9","after":"db364eb62d3194d30c3defb094c2d6c6069db5be","ref":"refs/heads/D5E6C3085CF669C3102897C2089A5B5C","pushedAt":"2024-08-06T17:41:34.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"alexeagle","name":"Alex Eagle","path":"/alexeagle","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/47395?s=80&v=4"},"commit":{"message":"fix(cli): relativize paths before applying lint fixes (#6281)\n\nThe paths we get from our gitdiff handling are always\nworkspace-relative, so we can't rely on them being cwd-relative.\n\nFixes https://github.com/aspect-build/aspect-cli/issues/672\n\n---\n\n### Changes are visible to end-users: no\n\n### Test plan\n\n- Manual testing; please provide instructions so we can reproduce:\n\nIn `rules_lint/example/src`, ran\n\n```\n % ~/Projects/silo/bazel-bin/cli/core/cmd/aspect/aspect_/aspect lint --fix :css\nINFO: Analyzed target //src:css (0 packages loaded, 0 targets configured).\nINFO: Found 1 target...\nAspect //tools/lint:linters.bzl%stylelint of //src:css up-to-date:\n  bazel-bin/src/css.AspectRulesLintStylelint.patch\n  bazel-bin/src/css.AspectRulesLintStylelint.report\n  bazel-bin/src/css.AspectRulesLintStylelint.report.exit_code\nINFO: Elapsed time: 0.170s, Critical Path: 0.00s\nINFO: 1 process: 1 internal.\nINFO: Build completed successfully, 1 total action\nLint results for //src:css:\n\n/private/var/tmp/_bazel_alexeagle/3eecd93732ac7c6f4f360a54a468da50/sandbox/darwin-sandbox/115/execroot/_main/bazel-out/darwin_arm64-fastbuild/bin/src/hello.css: line 11, col 5, error - Unexpected empty block (block-no-empty)\n/private/var/tmp/_bazel_alexeagle/3eecd93732ac7c6f4f360a54a468da50/sandbox/darwin-sandbox/115/execroot/_main/bazel-out/darwin_arm64-fastbuild/bin/src/hello.css: line 16, col 3, error - Unexpected duplicate \"color\" (declaration-block-no-duplicate-properties)\n\nSome problems have automated fixes available:\n\n  src/hello.css | 1 -\n  1 file, 1 deletion(-)\n\nPatched src/hello.css\n```\n\nGitOrigin-RevId: 72a798fba7b991e7d89af2fc5c94bebc936913dc","shortMessageHtmlLink":"fix(cli): relativize paths before applying lint fixes (#6281)"}},{"before":"54c998e974fa3eee2b5348297cc50d50b3a00801","after":"6dfe627f6e0fd049df241a7df73ae37ccedc6df9","ref":"refs/heads/D5E6C3085CF669C3102897C2089A5B5C","pushedAt":"2024-08-06T17:41:29.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"alexeagle","name":"Alex Eagle","path":"/alexeagle","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/47395?s=80&v=4"},"commit":{"message":"feat(CLI): Add new exit code for linting failures (#6267)\n\nCreate a new aspect specific linting failure exit code. Exit using that\ncode from the CLI lint handler when there are lint failures\n\n---\n\n### Changes are visible to end-users: no\n\n### Test plan\n\n- Manual testing; please provide instructions so we can reproduce:\n\nI have created a series of lint failures to test this. Will be following\nup with tests at a later date\n\nGitOrigin-RevId: 86f5076b7e9fc32de1e7ac81cac7943b12b19f27","shortMessageHtmlLink":"feat(CLI): Add new exit code for linting failures (#6267)"}},{"before":"afba59d399e9e48a23ef14be424626c51d319049","after":"54c998e974fa3eee2b5348297cc50d50b3a00801","ref":"refs/heads/D5E6C3085CF669C3102897C2089A5B5C","pushedAt":"2024-08-06T17:41:25.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"alexeagle","name":"Alex Eagle","path":"/alexeagle","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/47395?s=80&v=4"},"commit":{"message":"feat(cli): declare starzelle rule imports by attribute (#6207)\n\nThis changes target dependencies from being declared per-rule to\nper-attribute. This way a generated target can easily have multiple\nattributes that depend on other targets.\n\nThe idea of declaring one set of `Imports` per generated target comes\nfrom gazelle which was originally designed with only\n`go_{library,binary}(deps)` in mind... one set of `deps` per rule.\nHowever other rules may have multiple attributes that must be resolved\nso putting all dependencies (\"imports\") into a single array is unclear\nand not ideal.\n\n---\n\n### Changes are visible to end-users: no\n\n### Test plan\n\n- Covered by existing test cases\n- New test cases added\n\nGitOrigin-RevId: c350c412081550f755788276882c572076bc5559","shortMessageHtmlLink":"feat(cli): declare starzelle rule imports by attribute (#6207)"}},{"before":"d2c52270375761a32e849cc67e90eaca39734741","after":"afba59d399e9e48a23ef14be424626c51d319049","ref":"refs/heads/D5E6C3085CF669C3102897C2089A5B5C","pushedAt":"2024-08-06T17:41:20.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"alexeagle","name":"Alex Eagle","path":"/alexeagle","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/47395?s=80&v=4"},"commit":{"message":"feat(cli): add starzelle source parsing via regex, json, raw text (#6195)\n\nNon-treesitter queries for things like simple text, regex for\nmatching/filtering text, jq for matching/filtering json.\n\nWithin go the starzelle plugins just need to construct:\n```\nplugin.QueryDefinition{\n\tFilter:    \"*.x\",\n\tProcessor: func(file, queries, *results),\n\tParams:    paramsToFunc,\n}\n```\n\nNote the processor accepts a set of queries for the common case where\nthe file is parsed and then multiple queries run against the parsed\nvalue (such as an AST or parsed JSON etc).\n\nThe `Processor` fills `results[queryKey] = queryResult` with whatever\nvalue it wants, ideally something that implements `starlark.Value` so it\ncan be used by plugins written in starlark.\n\nA few builtin `Processor`s have been defined such as:\n* `raw`: simply return the full file as text\n* `json`: run a jq filter on a blob of json and return the result of\nthat filter\n* `regex`: run a regex on the file and return an array of `QueryMatch`s,\neach containing the match `result` and `captures`\n* `ast`: the existing tree-sitter API also returning an array of\n`QueryMatch`s\n\nThese can be passed as the `QueryDefinition{Processor}` for use of these\nbuiltin processors. The starlark API provides factory methods to\nconstruct these builtin query types.\n\n---\n\n### Changes are visible to end-users: no\n\n### Test plan\n\n- New test cases added\n\nGitOrigin-RevId: 111ed5a54c01d55415c94bda338fd18b287d6e3f","shortMessageHtmlLink":"feat(cli): add starzelle source parsing via regex, json, raw text (#6…"}},{"before":"3e851c965d195b6d4f0d853fba024a82f0e2dd1b","after":"d2c52270375761a32e849cc67e90eaca39734741","ref":"refs/heads/D5E6C3085CF669C3102897C2089A5B5C","pushedAt":"2024-08-06T17:41:15.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"alexeagle","name":"Alex Eagle","path":"/alexeagle","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/47395?s=80&v=4"},"commit":{"message":"fix(cli): support gazelle resolution of esm imports of URLs (#6262)\n\nThe go `path.Clean` breaks URLs such as changing `://` to `:/` so it\nshould only be used for what we assume to be paths. This will include\nrelative paths, absolute paths (which might be npm packages), but now\nexcludes anything with a protocol.\n\n---\n\n### Changes are visible to end-users: no\n\n### Test plan\n\n- Covered by existing test cases\n- New test cases added\n\nGitOrigin-RevId: da73e1120ff77f8d0a4a890ed6c9935276951554","shortMessageHtmlLink":"fix(cli): support gazelle resolution of esm imports of URLs (#6262)"}},{"before":"abe5612564c932a53e289451d02c24e3eb82b71f","after":"3e851c965d195b6d4f0d853fba024a82f0e2dd1b","ref":"refs/heads/D5E6C3085CF669C3102897C2089A5B5C","pushedAt":"2024-08-06T17:41:10.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"alexeagle","name":"Alex Eagle","path":"/alexeagle","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/47395?s=80&v=4"},"commit":{"message":"fix(cli): respect js_ignore_imports for tsconfig deps (#6261)\n\nTS config files should respect the `js_ignore_imports` just like imports\nfrom .ts files.\n\nFor example sometimes tsconfig files will reference things not available\nto gazelle, or BUILD file authors may not be able to edit the tsconfig\nfile.\n\n---\n\n### Changes are visible to end-users: no\n\n### Test plan\n\n- Covered by existing test cases\n- New test cases added\n\nGitOrigin-RevId: 8548103e655c60c6dd9d2194fa3db1d65a7fef1b","shortMessageHtmlLink":"fix(cli): respect js_ignore_imports for tsconfig deps (#6261)"}},{"before":"da5c9f298407e5cecf061afbc64dcef920791d8d","after":"abe5612564c932a53e289451d02c24e3eb82b71f","ref":"refs/heads/D5E6C3085CF669C3102897C2089A5B5C","pushedAt":"2024-08-06T17:41:06.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"alexeagle","name":"Alex Eagle","path":"/alexeagle","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/47395?s=80&v=4"},"commit":{"message":"feat(cli): add gazelle js_visibility directive (#6238)\n\nClose https://github.com/aspect-build/aspect-cli/issues/732\n\nFormat:\n```\n# gazelle:js_visibility [target] ...labels\n```\n\nThis is similar to\n[go_visibility](https://github.com/bazelbuild/bazel-gazelle#directives)\nwith a few key differences:\n* js does not have anything similar to the [go default visibility\nlogic](https://github.com/bazelbuild/bazel-gazelle/blob/v0.37.0/language/go/generate.go#L779),\nby default js does nothing (and users can provide their own defaults in\na macro)\n* `js_visibliity` is inherited by subdirs so you can have \"default\nlogic\" in a parent BUILD and don't have to repeat it\n* `js_visibility` overwrites any previous values (such as inherited\nones) instead of appending like go, if you want to append then just\nspecify multiple values when using the directive\n\n---\n\n### Changes are visible to end-users: no\n\n### Test plan\n\n- Covered by existing test cases\n- New test cases added\n\nGitOrigin-RevId: 12260503e76902f25bbf6714434e6f5ee21bc14b","shortMessageHtmlLink":"feat(cli): add gazelle js_visibility directive (#6238)"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAElLO5_wA","startCursor":null,"endCursor":null}},"title":"Activity · aspect-build/aspect-cli"}