bug: getting "You have configured asdf to preserve downloaded files" when I don't #1711

Mellbourn · 2024-01-21T22:01:02Z

Describe the Bug

Every time I install a new version using asdf, I always get the warning "You have configured asdf to preserve downloaded files"
To start with I had no .asdfrc file, so that was strange.
Then I even created a .asdfrc file with an explicit setting always_keep_download = no but the warning persists.

Content of my $HOME/.asdfrc file:

legacy_version_file = yes
always_keep_download = no

Steps to Reproduce

install something, e.g.

> asdf install direnv 2.31.0

Expected Behaviour

The following output only:

∗ Downloading and installing direnv...
The installation was successful!

Actual Behaviour

I always get two rows of warnings at the end of any installation:

∗ Downloading and installing direnv...
The installation was successful!
asdf: Warn: You have configured asdf to preserve downloaded files (with always_keep_download=yes or --keep-download). But
asdf: Warn: the current plugin (direnv) does not support that. Downloaded files will not be preserved.

Environment

OS:
Darwin Klass-MacBook-Pro-16-2023.local 23.2.0 Darwin Kernel Version 23.2.0: Wed Nov 15 21:55:06 PST 2023; root:xnu-10002.61.3~2/RELEASE_ARM64_T6020 arm64

SHELL:
zsh 5.9 (x86_64-apple-darwin23.0)

BASH VERSION:
5.2.26(1)-release

ASDF VERSION:
v0.14.0-ccdd47d

ASDF INTERNAL VARIABLES:
ASDF_DEFAULT_TOOL_VERSIONS_FILENAME=.tool-versions
ASDF_DATA_DIR=/Users/klas.mellbourn/.asdf
ASDF_DIR=/Users/klas.mellbourn/.asdf
ASDF_CONFIG_FILE=/Users/klas.mellbourn/.asdfrc

asdf plugins affected (if relevant)

ASDF INSTALLED PLUGINS:
bundler [email protected]:jonathanmorley/asdf-bundler.git master a461ac4
direnv [email protected]:asdf-community/asdf-direnv.git master a2219c2
java [email protected]:halcyon/asdf-java.git master fc28b48
lazydocker [email protected]:comdotlinux/asdf-lazydocker.git master abb6f71
nodejs [email protected]:asdf-vm/asdf-nodejs.git master c5b7c40
python [email protected]:danhper/asdf-python.git master 5e277e2
ruby [email protected]:asdf-vm/asdf-ruby.git master 7a22142

The text was updated successfully, but these errors were encountered:

Birdie0 · 2024-01-30T11:10:24Z

Warning was introduced in this commit but I guess condition is incorrect, it's triggered when both always_keep_download in .asdfrc isn't set to yes and --keep-download isn't provided, together with download directory missing.

reegnz · 2024-02-01T13:19:42Z

I'm also facing this issue.
Interestingly if I set always_keep_download = yes it doesn't complain, so I think the flag check is botched and does the reverse of what it actually should.

gurrenPizza · 2024-02-19T00:55:33Z

I've also faced this issue after adding the zsh-adf-direnv plugin for zsh. It is the same message and it showed up the first time I ran terminal after installing it, but I've managed to install sqlite (which is what I wanted to install with asdf) through asdf without the message and it didn't show up the next times I opened terminal.

Environment:

OS: Pop!_OS 22.04 LTS x86_64 
Shell: zsh 5.8.1
BASH version: 5.1.16(1)-release
asdf version: v0.14.0-ccdd47d

Fixes asdf-vm#1711

klippx · 2024-04-19T08:56:14Z

@Mellbourn Hello there! 👋

I also have this issue, I am not using a .asdfrc but rather a .tool-versions and I am getting this warning on CI only, from the action asdf-vm/actions/install@v2. I guess it could be related.

Will the PR be merged "soon" ? 😅

doolio · 2024-04-25T12:00:56Z

I also experience this behaviour with asdf v0.14.0-ccdd47d.

Currently, the warning which is intended to alert users that the download directory can't be kept only appears if they haven't asked for it to be. This change just rearranges the logic a bit so that the warning instead only appears if the download directory *should* be kept, but *can't* be kept (because it doesn't exist). fixes asdf-vm#1711

benblank · 2024-05-12T17:13:29Z

Looking at the current code, it does indeed look like the test is "reversed", but in the sense that the existing test needed to be inverted (and the clauses rearranged) in 19515ed, but wasn't. Probably just a simple brain fart. 🙂

asdf/lib/functions/installs.bash

Lines 237 to 246 in ccdd47d

    
           # Remove download directory if --keep-download flag or always_keep_download config setting are not set 
        
           always_keep_download=$(get_asdf_config_value "always_keep_download") 
        
           if [ ! "$keep_download" = "true" ] && [ ! "$always_keep_download" = "yes" ]; then 
        
             if [ -d "$download_path" ]; then 
        
               rm -r "$download_path" 
        
             else 
        
               printf '%s\n' "asdf: Warn: You have configured asdf to preserve downloaded files (with always_keep_download=yes or --keep-download). But" >&2 
        
               printf '%s\n' "asdf: Warn: the current plugin ($plugin_name) does not support that. Downloaded files will not be preserved." >&2 
        
             fi 
        
           fi

Basically, the current logic is "if not should-keep, (if exists, delete, else, warn)" but needs to be "if should-keep, (if not exists, warn), else (if exists, delete)". I just put together PR #1756, which should hopefully fix things.

Mellbourn added the bug label Jan 21, 2024

stefan-karlsson mentioned this issue Feb 18, 2024

"Downloaded files will not be preserved." asdf-vm/asdf-ruby#384

Open

Birdie0 added a commit to Birdie0/asdf that referenced this issue Feb 19, 2024

Fix keep_download condition

c340e7d

Fixes asdf-vm#1711

Birdie0 mentioned this issue Feb 19, 2024

fix: keep_download condition #1721

Closed

Birdie0 added a commit to Birdie0/asdf that referenced this issue Feb 19, 2024

fix: keep_download condition

736f49d

Fixes asdf-vm#1711

Birdie0 added a commit to Birdie0/asdf that referenced this issue Feb 19, 2024

fix: keep_download condition

4bb5473

Fixes asdf-vm#1711

Birdie0 added a commit to Birdie0/asdf that referenced this issue Feb 19, 2024

fix: keep_download condition

947f19b

Fixes asdf-vm#1711

C0deBr3ak3r mentioned this issue May 3, 2024

bug: always_keep_download has a wrong warning logic #1752

Closed

benblank mentioned this issue May 12, 2024

fix: Only display the "can't keep downloads" warning when asked to keep downloads #1756

Merged

Stratus3D closed this as completed in #1756 Aug 15, 2024

hyperupcall mentioned this issue Aug 15, 2024

bug: ASDF_CONFIG_FILE is ignored by asdf command #1772

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bug: getting "You have configured asdf to preserve downloaded files" when I don't #1711

bug: getting "You have configured asdf to preserve downloaded files" when I don't #1711

Mellbourn commented Jan 21, 2024

Birdie0 commented Jan 30, 2024 •

edited

Loading

reegnz commented Feb 1, 2024

gurrenPizza commented Feb 19, 2024

klippx commented Apr 19, 2024 •

edited

Loading

doolio commented Apr 25, 2024

benblank commented May 12, 2024

bug: getting "You have configured asdf to preserve downloaded files" when I don't #1711

bug: getting "You have configured asdf to preserve downloaded files" when I don't #1711

Comments

Mellbourn commented Jan 21, 2024

Describe the Bug

Steps to Reproduce

Expected Behaviour

Actual Behaviour

Environment

asdf plugins affected (if relevant)

Birdie0 commented Jan 30, 2024 • edited Loading

reegnz commented Feb 1, 2024

gurrenPizza commented Feb 19, 2024

klippx commented Apr 19, 2024 • edited Loading

doolio commented Apr 25, 2024

benblank commented May 12, 2024

Birdie0 commented Jan 30, 2024 •

edited

Loading

klippx commented Apr 19, 2024 •

edited

Loading