Limit fetch in submit to relevant branches #825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakejx
force-pushed
the
limit-submit-fetch-branches
branch
from
e560383
to
0d37e90
Compare
|
Hi @jakejx, thanks for the fix! I want to release version 0.7.0 with the current version of the code and then I'll merge this. |
arxanas
force-pushed
the
limit-submit-fetch-branches
branch
from
0d37e90
to
a0cf4de
Compare
|
Thanks for merging this! Fully understand the decision to delay the merge till after the release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up from my question in #671. I have made the changes to only fetch branches that are being pushed. I am testing it locally now and so far it seems to behave as expected but I am not sure if there are other edge cases to consider. I will continue to use this build for a few days and see if I encounter any other issues, but I figured it would be good to just open the MR for feedback first.
Thank you.
EDIT: not sure why the tests are failing for windows. They are passing on my machine.
EDIT2: I was not running tests for the entire workspace. Fixed.