Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

packages should not depend on setuptools #72

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

graingert
Copy link

No description provided.

@graingert
Copy link
Author

You already know that setuptools is installed here: https://github.com/curoverse/arvados/blob/master/sdk/python/setup.py#L11

@tetron
Copy link
Member

tetron commented Jul 13, 2018

Hi @graingert

Is this causing an actual problem for you or just a linting / style question? I believe the reason for this dependency is that:

  • We use pkg_resources at runtime (which is part of setuptools)
  • We build operating system packages (deb and rpm) which do not run setup.py at install time
  • The OS packages need an explicit dependency on setuptools in order to import pkg_resources

That said, the setuptools dependency could be moved to the OS package build if it causes a concrete problem for pip install.

@graingert
Copy link
Author

This causes a problem because we use pip-compile with --generate-hashes when we install the requirements.txt setuptools is considered a package without hashes defined

@tetron
Copy link
Member

tetron commented Jul 13, 2018

Thanks. I'll see what we can do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants