Upgrade to bstr 1.0.0 #2173
Merged
Upgrade to bstr 1.0.0 #2173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lopopolo
added a commit
that referenced
this pull request
Sep 10, 2022
The "system env" backend requires converting between bytes and platform strings. Previously this was done with routines which require the `bstr/std` feature. This feature is a bit heavy though ans the `OsString` specific bits are available in `scolapasta-path`. This commit also includes changes to get `spinoso-env` to build and test with no default features. Followup to #2173.
lopopolo
added a commit
that referenced
this pull request
Sep 10, 2022
The "system env" backend requires converting between bytes and platform strings. Previously this was done with routines which require the `bstr/std` feature. This feature is a bit heavy though ans the `OsString` specific bits are available in `scolapasta-path`. This commit also includes changes to get `spinoso-env` to build and test with no default features. Followup to #2173.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See:
serdeappears in the lockfile despite being unused and not being built due to:serdefeature is not specified BurntSushi/bstr#130Cargo.lockrust-lang/cargo#10801I am expecting to send a followup PR that drops the
stdfeature frombstrdep inspinoso-envin favor of replacing it withscolapasta-path.