Remove detailed compiler check #613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imwints
force-pushed
the
remove-compiler-check
branch
2 times, most recently
from
5bd8823
to
a027405
Compare
aristocratos
requested changes
Sep 30, 2023
imwints
force-pushed
the
remove-compiler-check
branch
from
a027405
to
fea0089
Compare
imwints
force-pushed
the
remove-compiler-check
branch
2 times, most recently
from
b93ab85
to
c2bf16a
Compare
Currently the Makefile tries to pick the latest version of g and overrides CXX when found. Since we give an error if the version of the compiler is not sufficient, we can remove this check. It's now possible to specify an older version (on purpose) and new compiler version don't need to be added manually.
imwints
force-pushed
the
remove-compiler-check
branch
from
c2bf16a
to
85d7503
Compare
aristocratos
approved these changes
Jan 3, 2024
|
@kz6fittycent |
|
@kz6fittycent |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently g is forced to be the latest intalled version
Since we give an error if the version of the compiler is not sufficient, we can remove this check/overwrite
It's now possible to specify an older version (on purpose) and new compiler version don't need to be added manually
Closes: #566