Refactor(eos_designs): Optimize handling of WAN internet exits #4372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4372
# Activate the virtual environment
source test-avd-pr-4372/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git https://github.com/ClausHolbechArista/avd.git@refactor/cv_deploy/optimize-handling-of-internet-exit#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git https://github.com/ClausHolbechArista/avd.git#/ansible_collections/arista/avd/,refactor/cv_deploy/optimize-handling-of-internet-exit --force
# Optional: Install AVD examples
cd test-avd-pr-4372
ansible-playbook arista.avd.install_examples |
ClausHolbechArista
added
the
cherry-pick-for-4.10.x
|
gmuloc
pushed a commit
to gmuloc/avd
that referenced
this pull request
Aug 28, 2024
ClausHolbechArista
pushed a commit
that referenced
this pull request
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Optimize handling of WAN internet exits
Related Issue(s)
Issue with errors from zscaler API calls for devices that do not use zscaler internet exit.
Component(s) name
arista.avd.eos_designsProposed changes
How to test
Already covered. Only performance / API usage impact.
Tested manually by Vinay and confirmed that with some auth issue all devices failed before and with the fix only the zscaler enabled devices failed.
Checklist
User Checklist
Repository Checklist