-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(artifacts): add note about server access #13425
Conversation
Signed-off-by: Chris Reilly <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't seem specific to archive logs, rather artifacts in general. Similarly, not about GKE, but any artifact retrieval: if you want to view them in the UI, the Server needs to be able to read them, yes
If there isn't a section about this already, this may make sense as its own separate section, either here or in the Server docs
The S3 IRSA section mentions the Server too. I would say to either follow that for now or make a new section about it properly. This page definitely needs a bit of a rewrite though (I started one many months ago actually, but the page is quite long so I never quite finished). |
This PR has been automatically marked as stale because it has not had recent activity and needs further changes. It will be closed if no further activity occurs. |
This PR has been automatically marked as stale because it has not had recent activity and needs further changes. It will be closed if no further activity occurs. |
This PR has been closed due to inactivity and lack of changes. If you would like to still work on this PR, please address the review comments and re-open. |
Motivation
When using Workload Identity the calling Kubernetes service account assumes GKE workload identity if it is annotated to do so, but per current docs it isn't clear that there are at least two service accounts that will need to be able to call the bucket. I am raising this change to help others avoid finding 500 errors when trying to retrieve archived logs for Workflows.
Modifications
Added docs content to explain that argo-server needs Workload identity enabled for use with Archive Logs
Verification
n/a