Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: archive gc support filter by prefix. Fixes #13336 #13378

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

qingfeng777
Copy link
Contributor

@qingfeng777 qingfeng777 commented Jul 22, 2024

Fixes #13336

Motivation

enable archive gc support filter by prefix

Modifications

add KeepPrefixes field in persist config, and send it to gc function.

Verification

run locally and tested

@qingfeng777 qingfeng777 marked this pull request as ready for review July 22, 2024 16:09
@qingfeng777 qingfeng777 marked this pull request as draft July 22, 2024 16:09
@qingfeng777 qingfeng777 changed the title feat: archive gc support filter by prefix. Fixes #13309 feat: archive gc support filter by prefix. Fixes #13336 Jul 22, 2024
@qingfeng777 qingfeng777 marked this pull request as ready for review July 22, 2024 17:08
Copy link
Contributor

@agilgur5 agilgur5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is further design discussion ongoing in the issue

@agilgur5 agilgur5 added area/workflow-archive area/gc Garbage collection, such as TTLs, retentionPolicy, delays, and more labels Aug 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/gc Garbage collection, such as TTLs, retentionPolicy, delays, and more area/workflow-archive
Projects
None yet
Development

Successfully merging this pull request may close these issues.

filter for archive ttl (by name or SQL)
2 participants