feat(ui): Retry a single workflow step manually #13343
Conversation
Signed-off-by: Adrien Delannoy <[email protected]>
agilgur5
changed the title
Signed-off-by: Adrien Delannoy <[email protected]>
|
Almost all of my attempts to do retries on coinflip-recursive result in a broken workflow. I know this is almost certainly outside the scope of the UI changes, but you could you check that I'm not just doing it wrong please @Adrien-D? |
|
I get a broken workflow as well I might do something wrong but can't see where {
"parameters": [],
"restartSuccessful": true,
"nodeFieldSelector": "id=${nodeId}"
} |
There was a problem hiding this comment.
LGTM
@isubasinghe is working on the problematic retry cases we found, but they're not directly related to this issue as they can already be invoked via the CLI.
|
This is currently breaking CI on |
Attempting to build the UI on `main` currently fails with the following error: ``` ERROR in ./src/app/workflows/components/retry-workflow-node-panel.tsx 26:0-43 Module not found: Error: Can't resolve '../../shared/utils' in '/home/vscode/go/src/github.com/argoproj/argo-workflows/ui/src/app/workflows/components' ``` This is happening due to a merge conflict between argoproj#13343 and argoproj#13339. The latter was merged first and deleted `ui/src/app/shared/utils.ts`, which the former is importing. The reason the CI build didn't fail for the former PR is that the branch wasn't up-to-date with `main` at the time of merge. Signed-off-by: Mason Malone <651224 [email protected]>
I'm guessing this is the source for #13692? There's wider bugs (or perhaps odd behavior?) there per my comments there pointing to #12543 and #12553 (comment) et al |
There was a problem hiding this comment.
It seems like there's some consolidation and simplification that could be done here
ui/src/app/workflows/components/workflow-node-info/workflow-node-info.tsx
Show resolved
Hide resolved
ui/src/app/workflows/components/workflow-node-info/workflow-node-info.tsx
Show resolved
Hide resolved
agilgur5
added
the
area/retry-manual
|
Resolved my above comment on simplification in #13814 |
Fixes #10139
Motivation
Add the ability to manually retry a single step on workflows.
Modifications
I based my changes on the retry workflow, but abstracting the
Node Field Selectorwith the current selected node, less flexible but very user friendly.Verification
See screenshots