refactor(misconf): use slog #7295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: nikpivkin <[email protected]>
Signed-off-by: nikpivkin <[email protected]>
Signed-off-by: nikpivkin <[email protected]>
Signed-off-by: nikpivkin <[email protected]>
Signed-off-by: nikpivkin <[email protected]>
Signed-off-by: nikpivkin <[email protected]>
6 tasks
Signed-off-by: nikpivkin <[email protected]>
simar7
reviewed
Aug 17, 2024
Comment on lines
199
to
210
| p.logger.Debug("Added input variables from tfvars", log.Int("count", len(inputVars))) | ||
|
|
||
| for _, varBlock := range blocks.OfType("variable") { | ||
| if varBlock.GetAttribute("default") == nil { | ||
| if _, ok := inputVars[varBlock.TypeLabel()]; !ok { | ||
| p.logger.Warn( | ||
| "Variable was not found in the environment or variable files. Evaluating may not work correctly.", | ||
| log.String("variable", varBlock.TypeLabel()), | ||
| ) | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Done 1cb0263
Also changed the wording of the logs to mean missing values rather than missing variables/parameters.
simar7
reviewed
Aug 17, 2024
Comment on lines
62
to
63
| opt.Debug("Found a token for the registry at %s", hostname) | ||
| opt.DebugLogger.Debug("Found a token for the registry", log.String("hostname", hostname)) |
There was a problem hiding this comment.
It seems a little too verbose to have opt.DebugLogger.Debug. Could we rename it better?
There was a problem hiding this comment.
Renamed DebugLogger to Logger b2cdb99
Signed-off-by: nikpivkin <[email protected]>
Signed-off-by: nikpivkin <[email protected]>
|
@nikpivkin looks like we have some merge conflicts to resolve prior to merging. |
|
@simar7 Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improves the logging in the IaC package. The slog package is now used for logging, which aligns the logging style with Trivy.
Changes:
Small refactoring: since no options are now passed to IaC parsers, unnecessary interfaces have been removed.
Related issues
Before
After
Checklist