Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(misconf): support for ignore by nested attributes #7205

Merged
merged 3 commits into from
Aug 28, 2024
Merged

feat(misconf): support for ignore by nested attributes #7205

merged 3 commits into from
Aug 28, 2024

Conversation

nikpivkin
Copy link
Contributor

@nikpivkin nikpivkin commented Jul 22, 2024 •
edited
Loading

Description

Added ability to ignore by nested attributes and values.

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@nikpivkin nikpivkin marked this pull request as ready for review August 6, 2024 08:48
@nikpivkin nikpivkin requested a review from simar7 as a code owner August 6, 2024 08:48
simar7
simar7 reviewed Aug 8, 2024
View reviewed changes
pkg/iac/scanners/terraform/ignore_test.go Outdated
// trivy:ignore:*[secure_settings.0.enabled=false]
// trivy:ignore:*[secure_settings.enabled=false]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's add these two as separate test cases so they're both documented in behavior.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done d71e6ac

@nikpivkin
fix block access by index
d71e6ac 
Signed-off-by: nikpivkin <[email protected]>
@simar7 simar7 self-requested a review August 28, 2024 23:25
@simar7 simar7 added this pull request to the merge queue Aug 28, 2024
Merged via the queue into aquasecurity:main with commit 44e4686 Aug 28, 2024
17 checks passed
@aqua-bot aqua-bot mentioned this pull request Aug 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simar7 simar7 simar7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nikpivkin @simar7