Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow commas in passwords so long as only one username is passed #7044

Closed
wants to merge 1 commit into from

Conversation

btoews
Copy link

@btoews btoews commented Jun 27, 2024

Description

It's a bit tricky to use Trivy with the Fly.io registry because Fly.io tokens often contain commas. Trivy allows multiple, comma separated passwords to be sent and complains if the number of usernames doesn't match the number of passwords.

In the case where one username and multiple passwords is set, this PR rejoins the passwords with commas. This seems like a good balance between allowing for multiple credentials to be specified and allowing for commas in passwords.

Related issues

#7043

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@btoews btoews requested a review from knqyf263 as a code owner June 27, 2024 13:16
@CLAassistant
Copy link

CLAassistant commented Jun 27, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

This PR is stale because it has been labeled with inactivity.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and will be auto-closed. label Aug 27, 2024
@github-actions github-actions bot closed this Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and will be auto-closed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants