Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(nodejs): add pnpm support #2414

Merged
merged 8 commits into from
Jun 29, 2022
Merged

feat(nodejs): add pnpm support #2414

merged 8 commits into from
Jun 29, 2022

Conversation

mycodeself
Copy link
Contributor

Description

This PR aims to add support for pnpm added in aquasecurity/go-dep-parser#106

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@knqyf263 knqyf263 marked this pull request as ready for review June 29, 2022 10:30
@knqyf263 knqyf263 self-requested a review as a code owner June 29, 2022 10:30
@knqyf263 knqyf263 merged commit c36a373 into aquasecurity:main Jun 29, 2022
@knqyf263
Copy link
Collaborator

Looks like it has been almost done, so I've merged it. Thanks for your great contribution!

@mycodeself
Copy link
Contributor Author

mycodeself commented Jun 29, 2022 via email •
edited
Loading

@knqyf263
Copy link
Collaborator

Oh, I completely forgot the documentation. Thanks for the good catch!

@mycodeself mycodeself deleted the feat-add-pnpm-support branch June 29, 2022 10:40
@06kellyjac
Copy link
Contributor

looking forward to this making a release :) thanks @mycodeself

@knqyf263 knqyf263 mentioned this pull request Jun 29, 2022
Closed
@mycodeself mycodeself mentioned this pull request Jun 29, 2022
Merged
7 tasks
@ManAnRuck
Copy link

Hi I am new here. Is https://aquasecurity.github.io/trivy/v0.22.0/vulnerability/detection/language/ missing the the pnpm lockfile on this page?

@knqyf263
Copy link
Collaborator

You are referencing v0.22.0. Please see the latest version.
https://aquasecurity.github.io/trivy/v0.51/docs/coverage/language/nodejs/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knqyf263 knqyf263 knqyf263 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pnpm support
4 participants
@mycodeself @knqyf263 @06kellyjac @ManAnRuck