Use REST config instead of ClientConfig #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #66 /- ##
==========================================
Coverage 70.54% 70.72% 0.18%
==========================================
Files 5 5
Lines 387 386 -1
==========================================
Hits 273 273
Misses 99 98 -1
Partials 15 15 Continue to review full report at Codecov.
|
This updates the `NewWhoCan` method to take a `rest.Config` object instead of a `ClientConfig` object. This allows the consumer of the API to use a custom `rest.Config` object rather than relying on the one created from the `ClientConfig` object. This also removes the `clientConfig` field from the `WhoCan` object. It is only used within the `ActionFrom` method, and it is passed in as an argument. As a result, there is no need to store it on the `WhoCan` object. Signed-off-by: Bridget McErlean <[email protected]>
danielpacak
force-pushed
the
pass-rest-config
branch
from
f4fe984
to
4e273ca
Compare
Codecov Report
@@ Coverage Diff @@
## master #66 /- ##
==========================================
Coverage 70.46% 70.64% 0.18%
==========================================
Files 5 5
Lines 386 385 -1
==========================================
Hits 272 272
Misses 99 98 -1
Partials 15 15 Continue to review full report at Codecov.
|
danielpacak
approved these changes
Feb 19, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the
NewWhoCanmethod to take arest.Configobjectinstead of a
ClientConfigobject. This allows the consumer of the APIto use a custom
rest.Configobject rather than relying on the onecreated from the
ClientConfigobject.This also removes the
clientConfigfield from theWhoCanobject. Itis only used within the
ActionFrommethod, and it is passed in as anargument. As a result, there is no need to store it on the
WhoCanobject.
Signed-off-by: Bridget McErlean [email protected]