Add an AcceptBackoffHandler to the async server bootstraps
#2782
6
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Motivation When encountering a file descriptor limit we are currently closing the server socket when using the async bootstraps since the error caught is delivered via the `inbound` sequence of the server socket async sequence. # Modification This PR adds the `AcceptBackoffHandler` in the async bootstrap case to the pipeline to avoid us closing the server socket channel when we hit the file descriptor limit. # Result We are now gracefully handling file descriptor limits.
|
This seems reasonable for running out of descriptors, what other |
Lukasa
reviewed
Jul 15, 2024
| @@ -68,8 68,9 @@ public final class AcceptBackoffHandler: ChannelDuplexHandler, RemovableChannelH | |||
| scheduleRead(at: self.nextReadDeadlineNS!, context: context) | |||
| } | |||
| } | |||
| } else { | |||
There was a problem hiding this comment.
I'm inclined to make this behaviour configurable. Users may be relying on the existing reporting, which makes sense as a default behaviour, but for the use-case we have it may well be sensible to suppress the error when it is "handled".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When encountering a file descriptor limit we are currently closing the server socket when using the async bootstraps since the error caught is delivered via the
inboundsequence of the server socket async sequence.Modification
This PR adds the
AcceptBackoffHandlerin the async bootstrap case to the pipeline to avoid us closing the server socket channel when we hit the file descriptor limit.Result
We are now gracefully handling file descriptor limits.