feedback: Reanme NIOScheduledCallbackHandler.onSchedule to handleSche…

…duledCallback
apple · simonjbeaumont · Oct 3, 2024 · Jun 28, 2024 · Jun 28, 2024 · Jun 28, 2024
commit 2ec55431f8bddf3cdf4e209079da75beb9d76ed6
diff --git a/Benchmarks/Benchmarks/NIOPosixBenchmarks/Benchmarks.swift b/Benchmarks/Benchmarks/NIOPosixBenchmarks/Benchmarks.swift
@@ -96,7  96,7 @@ let benchmarks = {
         let loop = group.next()
 
         final class Timer: NIOScheduledCallbackHandler {
-            func onSchedule(eventLoop: some EventLoop) {}
             func handleScheduledCallback(eventLoop: some EventLoop) {}
         }
         let timer = Timer()
 

diff --git a/Sources/NIOCore/NIOScheduledCallback.swift b/Sources/NIOCore/NIOScheduledCallback.swift
@@ -19,7  19,7 @@ public protocol NIOScheduledCallbackHandler {
     /// This function is called at the scheduled time, unless the scheduled callback is cancelled.
     ///
     /// - Parameter eventLoop: The event loop on which the callback was scheduled.
-    func onSchedule(eventLoop: some EventLoop)
     func handleScheduledCallback(eventLoop: some EventLoop)
 }
 
 /// An opaque handle that can be used to cancel a scheduled callback.
@@ -79,7  79,7 @@ extension EventLoop {
     /// Default implementation of `scheduleCallback(at deadline:handler:)`: backed by `EventLoop.scheduleTask`.
     @discardableResult
     public func scheduleCallback(at deadline: NIODeadline, handler: some NIOScheduledCallbackHandler) -> NIOScheduledCallback {
-        let task = self.scheduleTask(deadline: deadline) { handler.onSchedule(eventLoop: self) }
         let task = self.scheduleTask(deadline: deadline) { handler.handleScheduledCallback(eventLoop: self) }
         return NIOScheduledCallback(self, task)
     }
 

diff --git a/Sources/NIOPosix/SelectableEventLoop.swift b/Sources/NIOPosix/SelectableEventLoop.swift
@@ -475,7  475,7 @@ Further information:
                 }
             #endif
             case .callback(let handler):
-                handler.onSchedule(eventLoop: self)
                 handler.handleScheduledCallback(eventLoop: self)
             }
         }
     }

diff --git a/Tests/NIOPosixTests/NIOScheduledCallbackTests.swift b/Tests/NIOPosixTests/NIOScheduledCallbackTests.swift
@@ -132,7  132,7 @@ fileprivate final class MockTimerHandler: NIOScheduledCallbackHandler {
     var firedCount = 0
     var timerDidFire = XCTestExpectation(description: "Timer fired")
 
-    func onSchedule(eventLoop: some EventLoop) {
     func handleScheduledCallback(eventLoop: some EventLoop) {
         self.firedCount  = 1
         self.timerDidFire.fulfill()
     }