Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix race in TCPThroughputBenchmark #2724

Merged
merged 1 commit into from
May 20, 2024
Merged

Fix race in TCPThroughputBenchmark #2724

merged 1 commit into from
May 20, 2024

Conversation

ser-0xff
Copy link
Contributor

@ser-0xff ser-0xff commented May 20, 2024

Fix race in TCPThroughputBenchmark

Motivation:

Fix for #2649

Modifications:

Start test after server handler got channelActive to avoid race.
I was not able to reproduce the crash locally but obviously there is a problem and the PR should fix it.

Result:

Performance test will not crash.

Copy link
Contributor

@Lukasa Lukasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a lovely fix, thanks!

@Lukasa Lukasa added the semver/none No version bump required. label May 20, 2024
@Lukasa Lukasa enabled auto-merge (squash) May 20, 2024 16:26
@Lukasa Lukasa merged commit 196ceab into apple:main May 20, 2024
8 of 9 checks passed
chkp-aviads added a commit to chkp-aviads/swift-nio that referenced this pull request Jul 21, 2024
* commit 'fc79798d5a150d61361a27ce0c51169b889e23de':
  NIOSendableBox: allow off-loop initialisation iff Value is Sendable (apple#2753)
  Throw an appropriate error from the writer when the channel closed (apple#2744)
  put snippet code inside @available function (apple#2750)
  fix link to NIOFileSystem from NIO index page (apple#2747)
  convert the NIOFileSystem example code to a Snippet (apple#2746)
  Silence warning about missing include in macOS builds (apple#2741)
  Correctly mark 304 as not having a response body (apple#2737)
  Update availability guard (apple#2739)
  Add API for setting last accessed and last modified file times (apple#2735)
  Add a fallback path if renameat2 fails (apple#2733)
  Release file handles back to caller on failure to take ownership (apple#2715)
  Add a version of 'write' for 'ByteBuffer' (apple#2730)
  Imrprove rename error (apple#2731)
  Remove storage indirection for FileSystemError (apple#2726)
  testSimpleMPTCP should not fail for ENOPROTOOPT (apple#2725)
  Fix race in TCPThroughputBenchmark (apple#2724)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver/none No version bump required.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants