Add some more Sendable annotations to NIOCore
#2656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glbrntt
approved these changes
Feb 19, 2024
# Motivation We have a few more warnings left under strict concurrency checking in `NIOCore`. This fixes the bulk of them that are not tied to `ChannelHandler` or `ChannelPipeline`. # Modification Add more `Sendable` and `@Sendable` annotations and make sure to use types that are `Sendable` annotated.
FranzBusch
force-pushed
the
fb-niocore-sendable-annotations
branch
from
61ba100
to
30749ba
Compare
FranzBusch
added
the
🔼 needs-minor-version-bump
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We have a few more warnings left under strict concurrency checking in
NIOCore. This fixes the bulk of them that are not tied toChannelHandlerorChannelPipeline.Modification
Add more
Sendableand@Sendableannotations and make sure to use types that areSendableannotated.