Fix warnings caused by not defining the feature macros. #2606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should define `_GNU_SOURCE` for all of the C modules, really. Relying on `features.h` doesn't work for modular headers.
|
@swift-server-bot test this please |
FranzBusch
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should define
_GNU_SOURCEfor all of the C modules, really. Relying onfeatures.hdoesn't work for modular headers.Motivation:
Unfortunately, the defaults in
<features.h>don't really work for modular headers, so we need to define_GNU_SOURCEin a couple more places (mostly to avoid a compiler warning).Modifications:
Add
_GNU_SOURCEin a couple of places.Result:
There shouldn't be a huge impact; we won't generate compiler warnings about
<features.h>in a couple of places where we were doing before (assuming modular headers).