Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NonBlockingFileIO: tolerate chunk handlers from other ELs #2562

Merged
merged 1 commit into from
Oct 19, 2023
Merged

NonBlockingFileIO: tolerate chunk handlers from other ELs #2562

merged 1 commit into from
Oct 19, 2023

Conversation

weissi
Copy link
Member

@weissi weissi commented Oct 19, 2023

Motivation:

Anywhere in SwiftNIO a user supplies a future, NIO should tolerate futures from any EL.
That wasn't the case in NonBlockingFileIO.readChunked.

Modifications:

Hop the chunkHandler's future to the correct EL.

Result:

More user-friendly and correct

@weissi weissi requested a review from Lukasa October 19, 2023 19:17
@Lukasa Lukasa added the semver/patch No public API change. label Oct 19, 2023
Lukasa
Lukasa approved these changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@Lukasa Lukasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one, thanks!

@Lukasa Lukasa enabled auto-merge (squash) October 19, 2023 19:20
@Lukasa Lukasa merged commit eb2757d into apple:main Oct 19, 2023
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lukasa Lukasa Lukasa approved these changes

Assignees
No one assigned
Labels
semver/patch No public API change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@weissi @Lukasa