Remove SPI from NIOAsyncChannel and new bootstrap methods
#2548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FranzBusch
force-pushed
the
fb-async-channel-api
branch
from
36d2d4d
to
26a2c17
Compare
Lukasa
approved these changes
Oct 11, 2023
FranzBusch
force-pushed
the
fb-async-channel-api
branch
3 times, most recently
from
6d411a0
to
a27b836
Compare
FranzBusch
commented
Oct 16, 2023
| try await channel.close() | ||
| try await channel.closeFuture.get() |
There was a problem hiding this comment.
This change is interesting. It took me a second to figure out what was going on but it looks like the compiler resolves to a different method when SPI was in play and it incorrectly resolved to the default init instead of the one overloaded with Outbound == Never. Removing the SPI changed that and the test correctly failed with Channel already closed
…gotiation and HTTP upgrade. # Motivation Over the past months, we have been working on new async bridges to make using NIO's `Channel` from Swift Concurrency possible. Since this work was far reaching we have opted to land all of it as SPI. Now the time has come and we feel confident enough to make the SPI official API. This comes after testing the new APIs in various scenarios such as HTTP 1&2, HTTP upgrades, protocol negotiation and in benchmarks. # Modification This PR removes the SPI from the `NIOAsyncChannel`, the bootstrap methods, protocol negotiation and HTTP upgrade. # Result Everyone can use the our new APIs🚀
FranzBusch
force-pushed
the
fb-async-channel-api
branch
from
a27b836
to
2a0aff7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Over the past months, we have been working on new async bridges to make using NIO's
Channelfrom Swift Concurrency possible. Since this work was far reaching we have opted to land all of it as SPI. Now the time has come and we feel confident enough to make the SPI official API. This comes after testing the new APIs in various scenarios such as HTTP 1&2, HTTP upgrades, protocol negotiation and in benchmarks.Modification
This PR removes the SPI from the
NIOAsyncChanneland the bootstrap methods. The other SPI usages will be removed in follow up PRs to keep the scope of the PRs relatively small.Result
Everyone can use the
NIOAsyncChannel🚀