-
Notifications
You must be signed in to change notification settings - Fork 728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sendable
types
#3291
Comments
Would be curious to know if some of this can be adopted earlier than the eventual 2.0 release -- I think at the minimum the immutable generated types, as well as configuration enums like |
Is the Apollo graph slack something that external folk can join? I'd love to have a sense of where you're going with Swift Concurrency so I can design my abstractions in a future-proofed way. |
Not the org internal Slack no. We do have the Apollo GraphQL Community on Discord though which has sections for clients, etc. I'll edit the description to put the context there instead.
We don't have anything to share right now. It's a bunch of disconnected conversations and issues; it needs to get brought into a single document where we can talk about everything collectively. |
With the recent announcement of Swift 5.10 being the last Swift 5 release, I think this needs higher priority. As we're likely going to see people using Swift 6 in their code bases starting in June with the Xcode 16 beta. |
any updates on this? |
Hello. Any news? |
Hi there! Also curious to know when this is going to be shipped. Had to do some hacks to migrate my codebase to swift 6 |
I am actively working on this right now. A lot of our types were not designed for I'm anticipating this is going to be a breaking change that requires some sort of migration. I'm working on making that migration as painless as possible for as many people as possible. I will give more updates as soon as I have them. |
As I'm going through and attempting to make things We're planning on doing an entire networking re-write to use async/await and Strict Concurrency as a major new version of the library. But for now, I'm hoping to just get 1.0 working with Strict Concurrency. I know we need to make the generated models and related types Is anyone currently having issues with Swift 6 related to those types? |
For me, the bar is being able to use
|
As far as my project goes, aside from the generated models, I'd say maybe things like cache policy. I'll add more if I can think of it. |
I think I'd be in need of the following, in addition to generated Data types that have been mentioned:
I don't think that list is completely definitive, as I'm also seeing how much road the following will take me down:
|
Adding one more to the list: If you expect a type to work safely across thread boundaries it'd be great to at least mark as |
Thank you all for the valuable feedback! After a lot of research, we've come to the conclusion that providing proper support for Swift 6 and structured concurrency is going to require breaking changes. I have put up an RFC for a 2.0 version of Apollo iOS that will support Swift 6. Please check it out and respond with any concerns or suggestions you have! |
Use case
Ensure that schema generated types, such as generated enums can conform to
Sendable
.Describe the solution you'd like
More context in https://apollograph.slack.com/archives/C049FKX5N74/p1700467655099039Original context is for generated types to conform to
Sendable
something like this:becomes..
The text was updated successfully, but these errors were encountered: