Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ephemeral instances no longer have any example data #29694

Closed
3 tasks
sadpandajoe opened this issue Jul 25, 2024 · 5 comments · Fixed by #29993
Closed
3 tasks

Ephemeral instances no longer have any example data #29694

sadpandajoe opened this issue Jul 25, 2024 · 5 comments · Fixed by #29993
Assignees

Comments

@sadpandajoe
Copy link
Member

Bug description

When you spin up an ephemeral instance in a PR, example data such as dashboard, charts, etc. no longer exist.

How to reproduce the bug

  1. Go to a PR
  2. Spin up an ephemeral
  3. Log into the ephemeral
  4. Go to the dashboard list

Notice that the dashboard list is empty where we used to have example dashboards.

Screenshots/recordings

No response

Superset version

master / latest-dev

Python version

3.9

Node version

16

Browser

Chrome

Additional context

No response

Checklist

  • I have searched Superset docs and Slack and didn't find a solution to my problem.
  • I have searched the GitHub issue tracker and didn't find a similar bug report.
  • I have checked Superset's logs for errors and if I found a relevant Python stacktrace, I included it here as text in the "additional context" section.
Copy link

dosubot bot commented Jul 25, 2024

Hey @sadpandajoe! I'm here to assist you with any bugs, questions, or contributions while we wait for a human maintainer. Let's tackle this together!

The example data such as dashboards and charts no longer exist when spinning up an ephemeral instance in a PR because the provided workflow configuration does not include any steps to load or initialize example data. To include example data, you need to add steps in the workflow to load the example data after the environment is spun up. You can use scripts like misc_dashboard.py to load example dashboards and charts, or leverage the ImportAssetsCommand from the superset.commands.importers.v1.assets module to import predefined configurations for databases, datasets, charts, and dashboards [1][2][3].

To continue talking to Dosu, mention @dosu.

@sadpandajoe
Copy link
Member Author

@michael-s-molina we tracked it down to your PR: #28789 that was causing this. Wondering if you have time to take a look at this?

@michael-s-molina
Copy link
Member

michael-s-molina commented Jul 26, 2024

@sadpandajoe @eschutho @rusackas I executed the load examples command many times in my dev environment so I believe if might be something with the ephemeral environment. Do you have any additional information about the error? Any logs?

I'm really busy for the next days so feel free to revert the PR if needed.

@rusackas
Copy link
Member

This might be a clue for anyone looking into this: #27633

@sadpandajoe
Copy link
Member Author

@michael-s-molina I've created this PR to revert in case if you can't get to this before 4.1 is ready: #29766. Will hold off from merging for now.

@sadpandajoe sadpandajoe linked a pull request Aug 22, 2024 that will close this issue
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants