[SPARK-49013] Change key in collationsMap for Map and Array types in scala #47497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@HyukjinKwon Please take a look if you can as you have the context from the same pyspark change. |
HyukjinKwon
approved these changes
Jul 27, 2024
|
Merged to master. |
ilicmarkodb
pushed a commit
to ilicmarkodb/spark
that referenced
this pull request
Jul 29, 2024
…scala
### What changes were proposed in this pull request?
When deserializing map/array that is not part of the struct field, the key in collation map should just be `{"element": collation}` instead of `{".element": collation}`.
### Why are the changes needed?
To be consistent with the behavior on the pyspark side (apache#46737).
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Unit tests.
### Was this patch authored or co-authored using generative AI tooling?
No.
Closes apache#47497 from stefankandic/complexTypeDeSer.
Authored-by: Stefan Kandic <[email protected]>
Signed-off-by: Hyukjin Kwon <[email protected]>
fusheng-rd
pushed a commit
to fusheng-rd/spark
that referenced
this pull request
Aug 6, 2024
…scala
### What changes were proposed in this pull request?
When deserializing map/array that is not part of the struct field, the key in collation map should just be `{"element": collation}` instead of `{".element": collation}`.
### Why are the changes needed?
To be consistent with the behavior on the pyspark side (apache#46737).
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Unit tests.
### Was this patch authored or co-authored using generative AI tooling?
No.
Closes apache#47497 from stefankandic/complexTypeDeSer.
Authored-by: Stefan Kandic <[email protected]>
Signed-off-by: Hyukjin Kwon <[email protected]>
attilapiros
pushed a commit
to attilapiros/spark
that referenced
this pull request
Oct 4, 2024
…scala
### What changes were proposed in this pull request?
When deserializing map/array that is not part of the struct field, the key in collation map should just be `{"element": collation}` instead of `{".element": collation}`.
### Why are the changes needed?
To be consistent with the behavior on the pyspark side (apache#46737).
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Unit tests.
### Was this patch authored or co-authored using generative AI tooling?
No.
Closes apache#47497 from stefankandic/complexTypeDeSer.
Authored-by: Stefan Kandic <[email protected]>
Signed-off-by: Hyukjin Kwon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
When deserializing map/array that is not part of the struct field, the key in collation map should just be
{"element": collation}instead of{".element": collation}.Why are the changes needed?
To be consistent with the behavior on the pyspark side (#46737).
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Unit tests.
Was this patch authored or co-authored using generative AI tooling?
No.