[improve][broker] Make cluster metadata init command support metadata config path #23269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
doc-required
lhotari
approved these changes
Sep 9, 2024
pulsar-broker/src/main/java/org/apache/pulsar/PulsarClusterMetadataSetup.java
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/PulsarClusterMetadataSetup.java
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #23269 /- ##
============================================
Coverage 73.57% 74.51% 0.93%
- Complexity 32624 33683 1059
============================================
Files 1877 1926 49
Lines 139502 145057 5555
Branches 15299 15864 565
============================================
Hits 102638 108088 5450
Misses 28908 28700 -208
- Partials 7956 8269 313
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Coselding
approved these changes
Sep 9, 2024
|
It seems that this is related to PIP-366 #23033 and should go only in master branch? |
michalcukierman
pushed a commit
to michalcukierman/pulsar
that referenced
this pull request
Sep 11, 2024
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Oct 28, 2024
… config path (apache#23269) (cherry picked from commit 46f99b9) (cherry picked from commit fa2e7d8)
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Nov 6, 2024
… config path (apache#23269) (cherry picked from commit 46f99b9) (cherry picked from commit fa2e7d8)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Nov 6, 2024
… config path (apache#23269) (cherry picked from commit 46f99b9) (cherry picked from commit fa2e7d8)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The pulsar configuration supported
metadataStoreConfigPathandconfigurationStoreConfigPath, but the cluster metadata init command does not have a place to set the config path.Modifications
Make cluster metadata init command support metadata config path
Documentation
docdoc-requireddoc-not-neededdoc-complete