[feat][broker] PIP-264: Add replication subscription stats #23026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
doc-required
dragosvictor
changed the title
…ication-subscription-stats
lhotari
approved these changes
Aug 28, 2024
|
I'll close and re-open to get a fresh run that runs with latest changes from master branch. |
|
/pulsarbot rerun-failure-checks |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #23026 /- ##
============================================
Coverage 73.57% 74.50% 0.92%
- Complexity 32624 33727 1103
============================================
Files 1877 1925 48
Lines 139502 144927 5425
Branches 15299 15843 544
============================================
Hits 102638 107976 5338
Misses 28908 28683 -225
- Partials 7956 8268 312
Flags with carried forward coverage won't be shown. Click here to find out more.
|
…ication-subscription-stats
|
/pulsarbot rerun-failure-checks |
liudezhi2098
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PIP-264
Motivation
Adds replicated subscription metrics, defined here and here, to the OpenTelemetry pipeline.
Modifications
pulsar_replicated_subscriptions_pending_snapshotscounter, opted to expose the number of snapshot operations attempted. The snapshot duration histogram maintains the number of operations completed. Using these values, the number of pending snapshots can be computed at any time.Verifying this change
This change added tests and can be verified as follows:
ReplicatedSubscriptionTest#testReplicatedSubscriptionAcrossTwoRegionsto cover the new metric values.Does this pull request potentially affect one of the following parts:
Documentation
docdoc-required[feat][doc] PIP-264: Add replication subscription metrics reference pulsar-site#941doc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: dragosvictor#40