Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][txn] Allow transaction owners to abort their own transactions via the abortTransaction admin API #22978

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

hrzzzz
Copy link
Contributor

@hrzzzz hrzzzz commented Jun 25, 2024

Motivation

PIP-325 (#21731) states that a transaction owner should be able to use the abortTransaction admin API to abort their own transactions, and that a super user can abort any transaction. However, the current implementation does not permit a transaction owner to access the abortTransaction admin API to abort their own transactions. This PR aims to resolve this issue.

Modifications

Allow transaction owners to abort their own transactions via the abortTransaction admin API

Verifying this change

  • Make sure that the change passes the CI checks.

This change added tests and can be verified as follows:

  • Added test in org.apache.pulsar.broker.admin.v3.AdminApiTransactionWithAuthTest#testAbortTransaction

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: hrzzzz#8

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-not-needed Your PR changes do not impact docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant