-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve][cli]Support for pulsar-shell persistent modes #22522
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work @sandeep-mst . A few minor review comments.
pulsar-client-tools/src/main/java/org/apache/pulsar/shell/PulsarShell.java
Outdated
Show resolved
Hide resolved
pulsar-client-tools/src/main/java/org/apache/pulsar/shell/PulsarShell.java
Outdated
Show resolved
Hide resolved
pulsar-client-tools/src/main/java/org/apache/pulsar/shell/PulsarShell.java
Outdated
Show resolved
Hide resolved
pulsar-client-tools/src/main/java/org/apache/pulsar/shell/PulsarShell.java
Outdated
Show resolved
Hide resolved
pulsar-client-tools/src/main/java/org/apache/pulsar/shell/PulsarShell.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this idea.
-
I think we should register the new commands like other commands in
registerProviders(..)
so automatic autocompletion will work for these modes too. -
I don't understand the title, what do you mean by persistent modes ? I think we need a better name for this feature.
-
We should add docs, at least in the help (might be mitigated by 1.)
spaces where required, single line variable, promptmessage value stays the same but the prompt varies
pulsar-client-tools/src/main/java/org/apache/pulsar/shell/PulsarShell.java
Outdated
Show resolved
Hide resolved
@sandeep-mst Have you considered addressing @nicoloboschi's review feedback? For example, windows netsh has the concept of contexts and subcontexts (top level is "context", which could have "subcontexts"). |
…Mode which will help in auto-completion
Hi @lhotari,
|
Fixes 21194 of apache/pulsar
Motivation
Pulsar shell doesn't support persistent mode for admin, client, config. If we need to run a lot of admin commands for example, we would need to prefix admin each time. This will provide an alternative approach.
Modifications
Modified so that
admin
,client
,config
commands individually will launch their own mode and prompt message also gets updated.exit
orquit
command will exit from the mode to the default mode.In the admin mode, we can run command
topics
instead ofadmin topics
.Verifying this change
(Please pick either of the following options)
This change is already covered by existing tests, such as (please describe tests).
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository:
cognitree#6