[improve][java-client] check consumer pause status before consumer receive/batchReceive #17182
Conversation
|
the doc for it doesn't say anything about stop receiving message instantly, I think current behavior is acceptable? |
User may expect stop receive instanly. Is it possible to change the api doc? |
| return pauseFuture.thenCompose((v) -> { | ||
| return internalReceiveAsync(); | ||
| }); |
There was a problem hiding this comment.
The solution would need to be optimized. Although using a CompletableFuture addresses the functional aspects, it's not optimal at all. For example, in this case, .thenCompose will create new objects on every call, also when pausing is disabled.
|
The pr had no activity for 30 days, mark with Stale label. |
Motivation
*consumer client has method pause(), but consumer is not really paused. paused consumer only stop send flow permit request to broker but broker still can push messages to consumer if there is already existed flow permit. consumer can get messages if it invoked consumer.receive(). This may mislead users since no message is expected after pause. *
Modifications
park for some time if consumer is paused. consumer hold prefetched messages in client cache.
Verifying this change
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
Check the box below or label this PR directly.
Need to update docs?
doc-required(Your PR needs to update docs and you will update later)
[ x]
doc-not-needed(already documented)
doc(Your PR contains doc changes)
doc-complete(Docs have been already added)