Fix LICENSE/LICENSE.bin for release #495
Conversation
jbonofre
requested review from
ashvina,
RussellSpitzer,
snazy,
vvcephei,
takidau,
jackye1995,
flyrain,
eric-maynard,
collado-mike,
ebyhr and
adutra
as code owners
Add LICENSE-BINARY-DIST and include the binary distributions
|
@snazy I nuked the |
| @@ -183,4 183,13 @@ tasks.register<Sync>("prepareDockerDist") { | |||
|
|
|||
| tasks.named("build").configure { dependsOn("prepareDockerDist") } | |||
|
|
|||
| distributions { | |||
There was a problem hiding this comment.
Hm - it looks like none of the dist(s) actually works.
./gradlew :polaris-dropwizard-service:assembleDist
generates TWO sets of distributions:
$ ls -1 dropwizard/service/build/distributions/
polaris-dropwizard-service-1.0.0-incubating-SNAPSHOT-license-report.zip
polaris-dropwizard-service-1.0.0-incubating-SNAPSHOT.tar
polaris-dropwizard-service-1.0.0-incubating-SNAPSHOT.zip
polaris-dropwizard-service-shadow-1.0.0-incubating-SNAPSHOT.tar
polaris-dropwizard-service-shadow-1.0.0-incubating-SNAPSHOT.zip
The "non shadow" one has the NOTICE & LICENSE files, but running polaris-dropwizard-service-1.0.0-incubating-SNAPSHOT/bin/polaris-service leads to
Error: Could not find or load main class org.apache.polaris.service.dropwizard.PolarisApplication
Caused by: java.lang.ClassNotFoundException: org.apache.polaris.service.dropwizard.PolarisApplication
The "shadow" does not have the NOTICE LICENSE files, but running polaris-dropwizard-service-shadow-1.0.0-incubating-SNAPSHOT/bin/polaris-dropwizard-service does something.
There was a problem hiding this comment.
Yes, the polaris-service script never worked (see #542 ). It's not related to this PR, it's like this for a while.
Good point about "shadow" distribution. I actually wonder if we need both (only one binary distribution is enough).
There was a problem hiding this comment.
Frankly speaking, I think it's even better to get #469 in and let it replace the DW stuff entirely. Especially given the amount of issues.
There was a problem hiding this comment.
Agree, but that's another PR/proposal/discussion 😄 . In the meantime, I propose:
- To use only one binary distribution (let me test both to see if one actually works 😄 )
- That's a short term solution waiting the "new" runtime
LICENSEto be included in source distributionLICENSE-BINARY-DISTand include in the binary distributions