Remove the obsolete SqlliteCallContextCatalogFactory #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This earlier vestigial option only works without any of the authz-aware layers, and for now there's no way to short-circuit through the authz-aware layers to delegate to any underlying Catalog implementation that doesn't cooperate with the main Polaris metadata. If we want to support this pattern in the future it'll require a more explicit delegator/wrapper pattern where either the authz hooks are simulated in some way or else there's a cooperative multi-phase commit protocol. In the meantime, this defunct option may just cause confusion and dependency-bloat.
…obsolete-basecatalogtype
|
Thanks for removing it, @dennishuo ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This earlier vestigial option only works without any of the authz-aware layers, and for now there's no way to short-circuit through the authz-aware layers to delegate to any underlying Catalog implementation that doesn't cooperate with the main Polaris metadata.
If we want to support this pattern in the future it'll require a more explicit delegator/wrapper pattern where either the authz hooks are simulated in some way or else there's a cooperative multi-phase commit protocol.
In the meantime, this defunct option may just cause confusion and dependency-bloat.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist:
Please delete options that are not relevant.