-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MNG-6869] New flag to verify Maven installation status #995
Open
mthmulders
wants to merge
44
commits into
apache:master
Choose a base branch
from
infosupport:mng-6869-new-flag-to-verify-maven-status
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
44 commits
Select commit
Hold shift click to select a range
904caa4
[MNG-6869] Initial idea
Giovds 2dab934
[MNG-6869] Further brainstorming
mthmulders 1082a0d
[MNG-6869] Refactor local variable name
Giovds 8d46d92
[MNG-6969] WIP commit
Giovds 9aaf62f
[MNG-6869] Correct way to find local repo path
mthmulders 57c7020
[MNG-6869] Use java.nio instead of java.io
Giovds 55f35fd
[MNG-6869] Use java.nio instead of java.io
mthmulders fdcce30
[MNG-6869] Implement verification of artifact resolution (WIP)
mthmulders e4ec517
[MNG-6869] Test artifact resolution with temporary local repository
mthmulders 77526f5
[MNG-6869] Setup checks for remote connections
Giovds fbbcc20
[MNG-6869] Formatting
mthmulders ba9354a
[MNG-6869] Refactor: rename method
mthmulders 85b0907
[MNG-6869] Formatting
mthmulders 12a6b4b
[MNG-6869] Verify connection to remote repositories
mthmulders 140a63c
[MNG-6869] Reformat with Spotless
mthmulders 7afb18e
[MNG-6869] Add todo to fix local repository issue
Giovds ca4cb33
[MNG-6869] Narrow declaration of thrown exception
mthmulders 0764fd0
[MNG-6869] Refine detection of possible connection issues
mthmulders 30c9649
[MNG-6869] Use local repository correctly
Giovds d134358
[MNG-6869] Clean up temp file after usage
Giovds 6ba97e6
[MNG-6869] Include local repository path in issue text
mthmulders 79338ae
[MNG-6869] Mention local repo check has been completed
mthmulders b470aca
[MNG-6869] Output detected issues prefixed with a number
mthmulders 8629a8a
[MNG-6869] Properly close streeam
mthmulders 7fcc380
[MNG-6869] Make logger a static constant
mthmulders 2b01442
[MNG-6869] Make it explicit we're populating instance variables
mthmulders 95c52f2
[MNG-6869] Reorder instance variables
mthmulders d0f3b29
[MNG-6869] Mark method arguments as final
mthmulders 58e2f46
[MNG-6869] Store temporary local repo as Path
mthmulders f67f7c3
[MNG-6869] Rename logger to LOGGER
mthmulders 27a7e0a
[MNG-6869] Checkstyle: redundant modifier
mthmulders d2416a2
[MNG-6869] Minor review points
mthmulders 2a9ce5e
[MNG-6869] Remove commented code
Giovds ed191ad
[MNG-6869] Use exception classification of Transporter
Giovds 6adddbd
[MNG-6869] Make formatException signature non-optional
Giovds 9443a2a
[MNG-6869] Remove unnecessary comment
Giovds 41177b3
[MNG-6869] Remove unused DI fields
Giovds fc2e7f7
[MNG-6869] Make no assumptions about the existence of Maven Central
mthmulders 2114cda
[MNG-6869] Simplify
mthmulders 853819c
[MNG-6869] Prevent possible ClassCastException
mthmulders f39aec2
[MNG-6869] Revert unrelated change
mthmulders 6c4348d
Merge branch 'master' into mng-6869-new-flag-to-verify-maven-status
Giovds eaf2421
[MNG-6869] Make it work with recent changes
Giovds 63006df
[MNG-6869] Make use of try with resources
Giovds File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
[MNG-6869] Reformat with Spotless
- Loading branch information
commit 140a63ccd43f067d53db2426d72e4e22d6272166
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is 1 step too much. Is this the only way to verify if a remote repository is accessible? If you need to use an explicit file instead of a directory, is it possible to use http HEAD ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to verify: are you referring to the fact that this code actually downloads a file (e.g., it could've been an HTTP HEAD request), or to the fact that the
--status
verifies if artifact resolution works?In the case of the former: is a remote repository required to support an HTTP HEAD request? Could we rely on the fact that if HTTP HEAD is OK, HTTP GET will be OK, too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It depends on what you define as "artifact resolution works". I'm not interested if the implementation is correct. I wish there's a way to only confirm that the connection works. It is about returning questions on StackOverflow that say Maven can't download things, but it is just that it cannot reach a repository. Possible rootcauses are missing proxies (or misconfigured) and misconfigured mirrors. Maybe @michael-o or @cstamas can think of a low-level reliable way to conform this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From my experience this is not testing a random artifact which works but more enabling the aether logs which help, ultimately logging the request to be able to replay it with curl to do the check. Rest is random tests which can easily be proven false positive/negative due to proxies (correct) configuration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The goal of this code is not to explain what is wrong and how the user should fix it. I agree with @rmannibucau that the Aether logs are more suitable for that. What this code wants to do is tell the user they have a problem, without even building a project.
Ideally, in the case of the StackOverflow questions that @rfscholte refers to, we could say "please share the output of
mvn --status
". Their output might look like this for example:Even though this doesn't tell the user the solution, it points them in a few directions where they could look. It's a lot more compact than the complete Aether logs - which the user could still inspect, in case this message doesn't point them in the right direction already.