Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNG-7608] Make native transport the default #892

Merged
merged 4 commits into from
Dec 2, 2022

Conversation

cstamas
Copy link
Member

@cstamas cstamas commented Dec 2, 2022

This immediately cuts in "half" the count of HTTP requests against Maven Central or any major MRM.

Altering the meaning of "default": is now same as "auto", but still leaving it in place for future, as "default" at some point may again become something different than "native".


https://issues.apache.org/jira/browse/MNG-7608

This immediately cuts in "half" the count of HTTP requests
against Maven Central or any major MRM.

Altering the meaning of "default": is now same as "auto", but
still leaving it in place for future, as "default" at some
point may again become something different than "native".

---

https://issues.apache.org/jira/browse/MNG-7608
@cstamas cstamas self-assigned this Dec 2, 2022
@cstamas cstamas marked this pull request as ready for review December 2, 2022 07:29
@gnodet gnodet added this to the 4.0.0-alpha-3 milestone Dec 2, 2022
@cstamas cstamas marked this pull request as draft December 2, 2022 09:00
@cstamas
Copy link
Member Author

cstamas commented Dec 2, 2022

This PR needs more

@cstamas cstamas marked this pull request as ready for review December 2, 2022 09:45
@cstamas cstamas merged commit a840ba9 into apache:master Dec 2, 2022
@cstamas cstamas deleted the MNG-7608-default-transport branch December 2, 2022 15:12
@olamy
Copy link
Member

olamy commented Dec 2, 2022

before this it was possible for users to use their own wagon impls.
How is it possible now?

@cstamas
Copy link
Member Author

cstamas commented Dec 3, 2022

Nothing of legacy is lost, resolver transport (since Maven 3.0) was always like this:

maven  -> transport-wagon  -> wagon-http
      |                    -> wagon-foo
      |                    -> ...
       -> transport-http
       -> transport-jetty (or whatever)

All what happened here is the "transport-wagon" got it's original priority for resolver applied (is demoted). Hence, to use custom wagon, all you need is to set transport-wagon, and from there, everything is "as before". This change merely exposed (and reordered) the first level of "transort-*" nodes...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants