Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNG-7338] Automatically activate batch-mode and make output quiet when running in CI. #869

Merged

Conversation

MartinKanters
Copy link
Contributor

@MartinKanters MartinKanters commented Nov 10, 2022

After a discussion with @rmannibucau, @slawekjaranowski and @michael-o, I think this is the best solution.
The env CI check is done in Java code, making it easy to unit test. Also, a new flag had to be added to de-activate the CI=true behavior (named --force-interactive). To make it consistent I created an additional flag/alias to -B (--non-interactive). The flags were suggested by @michael-o since it's also used in other widely used CLI tools such as SVN.

Happy to hear your thoughts.

Relevant maven-integration-testing PR


Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MNG-XXX] SUMMARY, where you replace MNG-XXX
    and SUMMARY with the appropriate JIRA issue. Best practice is to use the JIRA issue
    title in the pull request title and in the first line of the commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the Core IT successfully.

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@MartinKanters MartinKanters force-pushed the feature/MNG-7338-automatic-non-interactive-mode-in-ci branch from 811592c to 9145ad1 Compare November 18, 2022 15:43
@MartinKanters MartinKanters force-pushed the feature/MNG-7338-automatic-non-interactive-mode-in-ci branch from 9145ad1 to 0e4ac27 Compare January 12, 2023 11:12
@MartinKanters MartinKanters force-pushed the feature/MNG-7338-automatic-non-interactive-mode-in-ci branch from 0e4ac27 to f6bb2be Compare March 24, 2023 09:43
@gnodet gnodet added this to the 4.0.0-alpha-6 milestone Jun 1, 2023
@MartinKanters
Copy link
Contributor Author

Thanks for merging master in and the approval @gnodet . I'm on holidays for the next couple of weeks, so feel free to merge it, if you want.

@gnodet gnodet force-pushed the feature/MNG-7338-automatic-non-interactive-mode-in-ci branch from 197df78 to 782f14c Compare June 6, 2023 23:07
@michael-o michael-o removed their request for review June 7, 2023 18:05
@gnodet gnodet merged commit ac0bc55 into master Jun 8, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants