[MNG-6797] - Remember if Maven model problems were encountered. #298
Conversation
Remember in MavenSession if Maven model problems were detected in DefaultGraphBuilder.
| * This indicates whether there were any problems detected when building Maven model. | ||
| * @return true if there were problems, false otherwise | ||
| */ | ||
| public boolean isProblems() { |
There was a problem hiding this comment.
That really hurts because the plural implies that you have a collection of problem, and not a boolean value. Moreover, third person singular with a plural reads horribly.
There was a problem hiding this comment.
As fas as I understand you want to memorize state. Can you provide an IT why this is necessary/benefit?
IME as someone who maintains Maven projects, people often introduce issues like that and they do not care to fix them unless their build breaks. Remembering in MavenSession that there were problems with the Maven model will allow me to write Maven Enforcer plugin rule that will read that and will fail the build.
I also fail to see how problems are detected, you only changed the signature of the method.
See org.apache.maven.graph.DefaultGraphBuilder#collectProjects. It prints the collected Maven model problems.
That really hurts because the plural implies that you have a collection of problem, and not a boolean value. Moreover, third person singular with a plural reads horribly.
I am open to suggestions for better name. I have only propagated the problems variable name upwards. One thing, I would like to keep the isX or getX for the getter as that would allow me, I believe, to use something like this ReflectionValueExtractor.evaluate("problems", session, false); to retrieve it in the Enforce rule easily, I hope.
Remember in MavenSession if Maven model problems were detected in
DefaultGraphBuilder.
The reason for this is to be able to read the problems flag in Maven Enforcer plugin rule that would stop build if any Maven model problems were encountered.
See also MNG-6797.
Following this checklist to help us incorporate your
contribution quickly and easily:
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
[MNG-XXX] - Fixes bug in ApproximateQuantiles,where you replace
MNG-XXXwith the appropriate JIRA issue. Best practiceis to use the JIRA issue title in the pull request title and in the first line of the
commit message.
mvn clean verifyto make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.