[MNG-6450] - Allow importing a POM with a classifier #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KathrynN
reviewed
Jul 25, 2018
|
|
||
| assertContains( result.getErrors().get( 0 ), | ||
| "'dependencyManagement.dependencies.dependency.classifier' for test:a:pom:cls must be empty" ); | ||
| assertViolations( result, 0, 0, 0 ); |
There was a problem hiding this comment.
If this is meant to signify that a violation is not thrown, would it be possible to create a method assertNoViolations( result ) ? Personally I feel as though it parses better.
There was a problem hiding this comment.
Hi @KathrynN, thank you for looking at the diff!
The assertViolations( result, 0, 0, 0 ); is used in 5 other test methods in addition to the one I've edited. Changing these would expand the scope of this concise diff to those unrelated test cases - is it, in your opinion, justified?
There was a problem hiding this comment.
Possibly in another story/issue, not here! Maybe mark that refactoring as good for beginners too :)
Thanks for the swift response
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes MNG-6450
Following this checklist to help us incorporate your
contribution quickly and easily:
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
[MNG-XXX] - Fixes bug in ApproximateQuantiles,where you replace
MNG-XXXwith the appropriate JIRA issue. Best practiceis to use the JIRA issue title in the pull request title and in the first line of the
commit message.
mvn clean verifyto make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
run-itsprofile, though...)If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
I hereby declare this contribution to be licensed under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.