Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MNG-5726 (backport for Maven 3.9) #1431

Merged
merged 1 commit into from
Mar 7, 2024
Merged

MNG-5726 (backport for Maven 3.9) #1431

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions maven-model-builder/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 32,6 @@ under the License.
<description>The effective model builder, with inheritance, profile activation, interpolation, ...</description>

<dependencies>
<dependency>
<groupId>org.codehaus.plexus</groupId>
<artifactId>plexus-utils</artifactId>
</dependency>
<dependency>
<groupId>org.codehaus.plexus</groupId>
<artifactId>plexus-interpolation</artifactId>
Expand Down
55 changes: 33 additions & 22 deletions .../main/java/org/apache/maven/model/profile/activation/OperatingSystemProfileActivator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 21,14 @@
import javax.inject.Named;
import javax.inject.Singleton;

import java.util.Locale;

import org.apache.maven.model.Activation;
import org.apache.maven.model.ActivationOS;
import org.apache.maven.model.Profile;
import org.apache.maven.model.building.ModelProblemCollector;
import org.apache.maven.model.profile.ProfileActivationContext;
import org.codehaus.plexus.util.Os;
import org.apache.maven.utils.Os;

/**
* Determines profile activation based on the operating system of the current runtime platform.
Expand All @@ -38,6 40,8 @@
@Singleton
public class OperatingSystemProfileActivator implements ProfileActivator {

private static final String REGEX_PREFIX = "regex:";

@Override
public boolean isActive(Profile profile, ProfileActivationContext context, ModelProblemCollector problems) {
Activation activation = profile.getActivation();
Expand All @@ -54,17 58,21 @@ public boolean isActive(Profile profile, ProfileActivationContext context, Model

boolean active = ensureAtLeastOneNonNull(os);

String actualOsName = context.getSystemProperties().get("os.name").toLowerCase(Locale.ENGLISH);
String actualOsArch = context.getSystemProperties().get("os.arch").toLowerCase(Locale.ENGLISH);
String actualOsVersion = context.getSystemProperties().get("os.version").toLowerCase(Locale.ENGLISH);

if (active && os.getFamily() != null) {
active = determineFamilyMatch(os.getFamily());
active = determineFamilyMatch(os.getFamily(), actualOsName);
}
if (active && os.getName() != null) {
active = determineNameMatch(os.getName());
active = determineNameMatch(os.getName(), actualOsName);
}
if (active && os.getArch() != null) {
active = determineArchMatch(os.getArch());
active = determineArchMatch(os.getArch(), actualOsArch);
}
if (active && os.getVersion() != null) {
active = determineVersionMatch(os.getVersion());
active = determineVersionMatch(os.getVersion(), actualOsVersion);
}

return active;
Expand All @@ -90,49 98,52 @@ private boolean ensureAtLeastOneNonNull(ActivationOS os) {
return os.getArch() != null || os.getFamily() != null || os.getName() != null || os.getVersion() != null;
}

private boolean determineVersionMatch(String version) {
String test = version;
private boolean determineVersionMatch(String expectedVersion, String actualVersion) {
String test = expectedVersion;
boolean reverse = false;

if (test.startsWith("!")) {
reverse = true;
test = test.substring(1);
final boolean result;
if (test.startsWith(REGEX_PREFIX)) {
result = actualVersion.matches(test.substring(REGEX_PREFIX.length()));
} else {
if (test.startsWith("!")) {
reverse = true;
test = test.substring(1);
}
result = actualVersion.equals(test);
}

boolean result = Os.isVersion(test);

return reverse ? !result : result;
return reverse != result;
}

private boolean determineArchMatch(String arch) {
String test = arch;
private boolean determineArchMatch(String expectedArch, String actualArch) {
String test = expectedArch;
boolean reverse = false;

if (test.startsWith("!")) {
reverse = true;
test = test.substring(1);
}

boolean result = Os.isArch(test);
boolean result = actualArch.equals(test);

return reverse ? !result : result;
}

private boolean determineNameMatch(String name) {
String test = name;
private boolean determineNameMatch(String expectedName, String actualName) {
String test = expectedName;
boolean reverse = false;

if (test.startsWith("!")) {
reverse = true;
test = test.substring(1);
}

boolean result = Os.isName(test);
boolean result = actualName.equals(test);

return reverse ? !result : result;
}

private boolean determineFamilyMatch(String family) {
private boolean determineFamilyMatch(String family, String actualName) {
String test = family;
boolean reverse = false;

Expand All @@ -141,7 152,7 @@ private boolean determineFamilyMatch(String family) {
test = test.substring(1);
}

boolean result = Os.isFamily(test);
boolean result = Os.isFamily(test, actualName);

return reverse ? !result : result;
}
Expand Down
233 changes: 233 additions & 0 deletions maven-model-builder/src/main/java/org/apache/maven/utils/Os.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 1,233 @@
/*
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/
package org.apache.maven.utils;

import java.util.Locale;
import java.util.stream.Stream;

/**
* OS support
*/
public class Os {

/**
* The OS Name.
*/
public static final String OS_NAME = System.getProperty("os.name").toLowerCase(Locale.ENGLISH);

/**
* The OA architecture.
*/
public static final String OS_ARCH = System.getProperty("os.arch").toLowerCase(Locale.ENGLISH);

/**
* The OS version.
*/
public static final String OS_VERSION = System.getProperty("os.version").toLowerCase(Locale.ENGLISH);

/**
* OS Family
*/
public static final String OS_FAMILY;

/**
* Boolean indicating if the running OS is a Windows system.
*/
public static final boolean IS_WINDOWS;

/**
* OS family that can be tested for. {@value}
*/
private static final String FAMILY_WINDOWS = "windows";

/**
* OS family that can be tested for. {@value}
*/
private static final String FAMILY_WIN9X = "win9x";

/**
* OS family that can be tested for. {@value}
*/
public static final String FAMILY_NT = "winnt";

/**
* OS family that can be tested for. {@value}
*/
private static final String FAMILY_OS2 = "os/2";

/**
* OS family that can be tested for. {@value}
*/
private static final String FAMILY_NETWARE = "netware";

/**
* OS family that can be tested for. {@value}
*/
private static final String FAMILY_DOS = "dos";

/**
* OS family that can be tested for. {@value}
*/
private static final String FAMILY_MAC = "mac";

/**
* OS family that can be tested for. {@value}
*/
private static final String FAMILY_TANDEM = "tandem";

/**
* OS family that can be tested for. {@value}
*/
private static final String FAMILY_UNIX = "unix";

/**
* OS family that can be tested for. {@value}
*/
private static final String FAMILY_OPENVMS = "openvms";

/**
* OS family that can be tested for. {@value}
*/
private static final String FAMILY_ZOS = "z/os";

/**
* OS family that can be tested for. {@value}
*/
private static final String FAMILY_OS390 = "os/390";

/**
* OS family that can be tested for. {@value}
*/
private static final String FAMILY_OS400 = "os/400";

/**
* OpenJDK is reported to call MacOS X "Darwin"
*
* @see <a href="https://issues.apache.org/bugzilla/show_bug.cgi?id=44889">bugzilla issue</a>
* @see <a href="https://issues.apache.org/jira/browse/HADOOP-3318">HADOOP-3318</a>
*/
private static final String DARWIN = "darwin";

/**
* The path separator.
*/
private static final String PATH_SEP = System.getProperty("path.separator");

static {
// Those two public constants are initialized here, as they need all the private constants
// above to be initialized first, but the code style imposes the public constants to be
// defined above the private ones...
OS_FAMILY = getOsFamily();
IS_WINDOWS = isFamily(FAMILY_WINDOWS);
}

private Os() {}

/**
* Determines if the OS on which Maven is executing matches the
* given OS family.
*
* @param family the family to check for
* @return true if the OS matches
*
*/
public static boolean isFamily(String family) {
return isFamily(family, OS_NAME);
}

/**
* Determines if the OS on which Maven is executing matches the
* given OS family derived from the given OS name
*
* @param family the family to check for
* @param actualOsName the OS name to check against
* @return true if the OS matches
*
*/
public static boolean isFamily(String family, String actualOsName) {
// windows probing logic relies on the word 'windows' in the OS
boolean isWindows = actualOsName.contains(FAMILY_WINDOWS);
boolean is9x = false;
boolean isNT = false;
if (isWindows) {
// there are only four 9x platforms that we look for
is9x = (actualOsName.contains("95")
|| actualOsName.contains("98")
|| actualOsName.contains("me")
// wince isn't really 9x, but crippled enough to
// be a muchness. Maven doesnt run on CE, anyway.
|| actualOsName.contains("ce"));
isNT = !is9x;
}
switch (family) {
case FAMILY_WINDOWS:
return isWindows;
case FAMILY_WIN9X:
return isWindows && is9x;
case FAMILY_NT:
return isWindows && isNT;
case FAMILY_OS2:
return actualOsName.contains(FAMILY_OS2);
case FAMILY_NETWARE:
return actualOsName.contains(FAMILY_NETWARE);
case FAMILY_DOS:
return PATH_SEP.equals(";") && !isFamily(FAMILY_NETWARE, actualOsName) && !isWindows;
case FAMILY_MAC:
return actualOsName.contains(FAMILY_MAC) || actualOsName.contains(DARWIN);
case FAMILY_TANDEM:
return actualOsName.contains("nonstop_kernel");
case FAMILY_UNIX:
return PATH_SEP.equals(":")
&& !isFamily(FAMILY_OPENVMS, actualOsName)
&& (!isFamily(FAMILY_MAC, actualOsName) || actualOsName.endsWith("x"));
case FAMILY_ZOS:
return actualOsName.contains(FAMILY_ZOS) || actualOsName.contains(FAMILY_OS390);
case FAMILY_OS400:
return actualOsName.contains(FAMILY_OS400);
case FAMILY_OPENVMS:
return actualOsName.contains(FAMILY_OPENVMS);
default:
return actualOsName.contains(family.toLowerCase(Locale.US));
}
}

/**
* Helper method to determine the current OS family.
*
* @return name of current OS family.
*/
private static String getOsFamily() {
return Stream.of(
FAMILY_DOS,
FAMILY_MAC,
FAMILY_NETWARE,
FAMILY_NT,
FAMILY_OPENVMS,
FAMILY_OS2,
FAMILY_OS400,
FAMILY_TANDEM,
FAMILY_UNIX,
FAMILY_WIN9X,
FAMILY_WINDOWS,
FAMILY_ZOS)
.filter(Os::isFamily)
.findFirst()
.orElse(null);
}
}
Loading
Loading