[MNG-7904] Use SettingsStaxReader/Writer for SettingsXpp3Reader/Writer #1285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnodet
approved these changes
Oct 19, 2023
gnodet
requested changes
Oct 19, 2023
maven-settings/src/main/java/org/apache/maven/settings/io/xpp3/SettingsXpp3Reader.java
Outdated
Show resolved
Hide resolved
maven-settings/src/main/java/org/apache/maven/settings/io/xpp3/SettingsXpp3Writer.java
Outdated
Show resolved
Hide resolved
michael-o
reviewed
Oct 19, 2023
| try { | ||
| return new Settings(delegate.read(reader)); | ||
| } catch (XMLStreamException e) { | ||
| throw new XmlPullParserException(e.getMessage(), null, e); |
There was a problem hiding this comment.
Can't we just pass the exception?
There was a problem hiding this comment.
Can't we just pass the exception?
Pass how / where ? We can't pass through, that would change the throws clause and break the API. Which would be problematic because that's the whole purpose of that class.
There was a problem hiding this comment.
That is not what I meant. Single arg ctor.
There was a problem hiding this comment.
Ww have two ctor
- XmlPullParserException(String s) - only message
- XmlPullParserException(String msg, XmlPullParser parser, Throwable chain)
so I choose second with cause exception
There was a problem hiding this comment.
Yeah, another one is missing for this case
There was a problem hiding this comment.
I think the xpp3 api may even predate chained exceptions that were introduced in JDK 1.4 ;-)
gnodet
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following this checklist to help us incorporate your
contribution quickly and easily:
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
[MNG-XXX] SUMMARY,where you replace
MNG-XXXandSUMMARYwith the appropriate JIRA issue.[MNG-XXX] SUMMARY.Best practice is to use the JIRA issue title in both the pull request title and in the first line of the commit message.
mvn clean verifyto make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.