LUCENE 9236 #1282
Draft
LUCENE 9236 #1282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juanka588
commented
Feb 24, 2020
| SparseNumericDocValues(IndexedDISI disi) { | ||
| this.disi = disi; | ||
| long ramBytesUsed = BASE_RAM_USAGE; | ||
| for (Accountable accountable : numerics.values()) { |
There was a problem hiding this comment.
now each entry implements accountable
juanka588
commented
Feb 24, 2020
| } | ||
| } | ||
|
|
||
| public long[] writeValues(FieldInfo field, DocValuesProducer valuesProducer, IndexOutput data, IndexOutput meta) throws IOException { |
There was a problem hiding this comment.
added data and meta index output
juanka588
commented
Feb 24, 2020
| long blockEndOffset; | ||
| LongValues values; | ||
|
|
||
| VaryingBPVReader(NumericEntry entry, RandomAccessInput slice, IndexInput data) throws IOException { |
juanka588
commented
Feb 24, 2020
| @@ -48,6 53,16 @@ public Lucene80BinaryConsumer(SegmentWriteState state) { | |||
| this.maxDoc = state.segmentInfo.maxDoc(); | |||
| } | |||
|
|
|||
| @Override | |||
| public CompositeFieldMetadata addBinary(FieldInfo field, DocValuesProducer valuesProducer, IndexOutput indexOutput) throws IOException { | |||
| ByteBuffersDataOutput delegate = ByteBuffersDataOutput.newResettableInstance(); | |||
There was a problem hiding this comment.
this can be replaced with a BinaryEntry Object
|
Please review each commit apart. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please provide a short description of the changes you're making with this pull request.
Solution
Please provide a short description of the approach taken to implement your solution.
Tests
Please describe the tests you've developed or run to confirm this patch implements the feature or solves the problem.
Checklist
Please review the following and check all that apply:
masterbranch.ant precommitand the appropriate test suite.