Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: Kafka Streams updates for 2.7.0 release #9773

Merged
merged 3 commits into from
Dec 22, 2020

Conversation

bbejeck
Copy link
Member

@bbejeck bbejeck commented Dec 21, 2020

Added upgrade-system-tests-27 module, updated settings.gradle and build.gradle for the new module, added the latest release to the streams_upgrade_test.py

For testing, I ran streams:testAll locally and everything passed.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@@ -30,7 30,7 @@
# broker 0.10.0 is not compatible with newer Kafka Streams versions
broker_upgrade_versions = [str(LATEST_0_10_1), str(LATEST_0_10_2), str(LATEST_0_11_0), str(LATEST_1_0), str(LATEST_1_1), \
str(LATEST_2_0), str(LATEST_2_1), str(LATEST_2_2), str(LATEST_2_3), \
str(LATEST_2_4), str(LATEST_2_5), str(LATEST_2_6), str(DEV_BRANCH)]
str(LATEST_2_4), str(LATEST_2_5), str(LATEST_2_6), str(LATEST_27), str(DEV_BRANCH)]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LATEST_27 musts be imported above.

Copy link
Member

@mjsax mjsax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but we should trigger a system test run before merging to make sure we did not miss anything.

@bbejeck
Copy link
Member Author

bbejeck commented Dec 21, 2020

@bbejeck
Copy link
Member Author

bbejeck commented Dec 21, 2020

Previous system test failed due to bad variable ref.

New system test https://jenkins.confluent.io/job/system-test-kafka-branch-builder/4328/

@mjsax mjsax merged commit b6891f6 into apache:trunk Dec 22, 2020
@bbejeck bbejeck deleted the MINOR_streams_updates_for_new_version branch January 4, 2021 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants