Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: Re-add Uniform assignor to the default ones #15269

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

dajac
Copy link
Member

@dajac dajac commented Jan 26, 2024

The uniform assignor got accidentally removed by #15158. This patch adds it back. I will make sure that we add a test to validate this when we add tests for the ConsumerGroupDescribe API.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@dajac dajac added the KIP-848 The Next Generation of the Consumer Rebalance Protocol label Jan 26, 2024
@dajac dajac requested a review from mimaison January 26, 2024 13:10
@dajac
Copy link
Member Author

dajac commented Jan 26, 2024

@mimaison @OmniaGM Could you please review?

Copy link
Collaborator

@OmniaGM OmniaGM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks a straight forward change. Sorry for dropping this one while moving Defaults out

@dajac
Copy link
Member Author

dajac commented Jan 26, 2024

@OmniaGM Thanks and no worries.

Copy link
Member

@mimaison mimaison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks for the fix

@dajac dajac merged commit 94ab8c1 into apache:trunk Jan 29, 2024
1 check failed
@dajac dajac deleted the minor-bring-back-uniform branch January 29, 2024 07:59
yyu1993 pushed a commit to yyu1993/kafka that referenced this pull request Feb 15, 2024
The uniform assignor got accidentally removed by apache#15158. This patch adds it back. 

Reviewers: Omnia G H Ibrahim <[email protected]>, Mickael Maison <[email protected]>
clolov pushed a commit to clolov/kafka that referenced this pull request Apr 5, 2024
The uniform assignor got accidentally removed by apache#15158. This patch adds it back. 

Reviewers: Omnia G H Ibrahim <[email protected]>, Mickael Maison <[email protected]>
Phuc-Hong-Tran pushed a commit to Phuc-Hong-Tran/kafka that referenced this pull request Jun 6, 2024
The uniform assignor got accidentally removed by apache#15158. This patch adds it back. 

Reviewers: Omnia G H Ibrahim <[email protected]>, Mickael Maison <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
KIP-848 The Next Generation of the Consumer Rebalance Protocol
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants