Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KAFKA-13930: Add 3.2.0 Streams upgrade system tests #12209

Merged
merged 6 commits into from
Jun 21, 2022
Merged

KAFKA-13930: Add 3.2.0 Streams upgrade system tests #12209

merged 6 commits into from
Jun 21, 2022

Conversation

cadonna
Copy link
Contributor

@cadonna cadonna commented May 25, 2022

Apache Kafka 3.2.0 was recently released. Now we need
to test upgrades from 3.2 to trunk in our system tests.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@divijvaidya
Copy link
Contributor

Should we add such PRs as part of our release activity checklist? (Ignore if it is already present there).

@cadonna
Copy link
Contributor Author

cadonna commented Jun 1, 2022

@divijvaidya This is the penultimate task in the release process (https://cwiki.apache.org/confluence/display/KAFKA/Release Process).

@cadonna cadonna force-pushed the AK13930-add_32_upgrade_comp_tests branch 2 times, most recently from 64aa852 to cb93d4f Compare June 2, 2022 18:31
@cadonna cadonna force-pushed the AK13930-add_32_upgrade_comp_tests branch from 64c9263 to a609868 Compare June 21, 2022 10:12
cadonna
cadonna commented Jun 21, 2022
View reviewed changes
streams/src/test/java/org/apache/kafka/streams/tests/SmokeTestUtil.java
Comment on lines -36 to -37
@Rule
public Timeout globalTimeout = Timeout.seconds(600);
Copy link
Contributor Author

@cadonna cadonna Jun 21, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to remove this since system tests do not have a dependency to junit that containsTimeout which led to ClassNotFoundException during system test executions. AFAICS, the timeout rule makes no sense here since this class and all child-classes except RelationalSmokeTestTest do not contain tests. I added the timeout rule to RelationalSmokeTestTest.

@cadonna
Copy link
Contributor Author

cadonna commented Jun 21, 2022

Link to successful system test run:
http://confluent-kafka-branch-builder-system-test-results.s3-us-west-2.amazonaws.com/2022-06-21--001.system-test-kafka-branch-builder--1655809886--cadonna--AK13930-add_32_upgrade_comp_tests--a609868f1b/report.html

bbejeck
bbejeck approved these changes Jun 21, 2022
View reviewed changes
Copy link
Member

@bbejeck bbejeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cadonna LGTM.

As a side note do want to consider trimming off some of the oldest versions from the compatibility tests?

@cadonna
Copy link
Contributor Author

cadonna commented Jun 21, 2022

As a side note do want to consider trimming off some of the oldest versions from the compatibility tests?

What would be a good cut-off point in your opinion?

@cadonna
Copy link
Contributor Author

cadonna commented Jun 21, 2022

Build failures are unrelated:

Build / ARM / Run ARM Build / org.apache.kafka.controller.QuorumControllerTest.testUnregisterBroker()
Build / ARM / Run ARM Build / org.apache.kafka.controller.QuorumControllerTest.testUnregisterBroker()
Build / PowerPC / Run PowerPC Build / org.apache.kafka.controller.QuorumControllerTest.testUnregisterBroker()
Build / JDK 17 and Scala 2.13 / org.apache.kafka.controller.QuorumControllerTest.testSnapshotOnlyAfterConfiguredMinBytes()
Build / JDK 17 and Scala 2.13 / org.apache.kafka.trogdor.coordinator.CoordinatorTest.testTaskRequestWithOldStartMsGetsUpdated()

@cadonna cadonna merged commit 4d53dd9 into apache:trunk Jun 21, 2022
mjsax pushed a commit to confluentinc/kafka that referenced this pull request Jun 30, 2022
@cadonna @mjsax
KAFKA-13930: Add 3.2.0 Streams upgrade system tests (apache#12209)
91c86a7 
* KAFKA-13930: Add 3.2.0 Streams upgrade system tests

Apache Kafka 3.2.0 was recently released. Now we need
to test upgrades from 3.2 to trunk in our system tests.

Reviewer: Bill Bejeck <[email protected]>
@fqaiser94 fqaiser94 mentioned this pull request Mar 6, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbejeck bbejeck bbejeck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cadonna @divijvaidya @bbejeck