Minor: Move trogdor out of tools and into its own project #10539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This moves Trogdor out of tools/ and into its own project. This would allow Trogdor to be linked against other libraries (for example, you could build a worker that links against k8s to trigger issues through it), without bringing those dependencies into Kafka itself through the tools project. It still keeps Trogdor in the CLASSPATH created in kafka-run-class.sh.
|
Looks good overall! Can you remove the jersey dependency from tools? Now that trogdor is in a separate subproject it should not be needed any more. Same with "activation" and "jetty". |
|
I echo Colin's comments. Otherwise looks great. I just built the project (with 4b6c476) and ran through the TROGDOR readme (https://github.com/apache/kafka/blob/trunk/TROGDOR.md) - it works great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves Trogdor out of tools/ and into its own project. This would
allow Trogdor to be linked against other libraries (for example, you
could build a worker that links against k8s to trigger issues through
it), without bringing those dependencies into Kafka itself through the
tools project.
It still keeps Trogdor in the CLASSPATH created in kafka-run-class.sh.
Tested by building, and running Trogdor in the resulting build.
Committer Checklist (excluded from commit message)