Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] When you choose to enable HTTPS, the port will be changed back to 443 by default. #2779

Closed
1 task done
shenliehuozhi opened this issue Oct 23, 2024 · 2 comments · Fixed by #2896
Closed
1 task done

[BUG] When you choose to enable HTTPS, the port will be changed back to 443 by default. #2779

shenliehuozhi opened this issue Oct 23, 2024 · 2 comments · Fixed by #2896
Labels
status: volunteer wanted task

Comments

@shenliehuozhi
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

我打算新建一个https页面可用性监测，按要求填写后
image
因为是https页面，点击开启https，此时端口会变成默认的443端口
image
如果稍不注意，就会导致配置错误。

Expected Behavior

建议将开启HTTPS这个选项，调整到端口选项前面，这样开启HTTPS默认是443，但是端口选项在后面，用户明白还需修改对应端口号
image

Steps To Reproduce

No response

Environment

HertzBeat version(s):v1.6.0

Debug logs

No response

Anything else?

No response
@shenliehuozhi shenliehuozhi added the bug Something isn't working label Oct 23, 2024
@zqr10159 zqr10159 added status: volunteer wanted task and removed bug Something isn't working labels Oct 29, 2024
@tomsun28
Copy link
Contributor

hi, this is a feature, auto config default ssl port 443.

@tomsun28 tomsun28 changed the title [BUG] <title>选择开启HTTPS时，会默认修改端口回443 [BUG] When you choose to enable HTTPS, the port will be changed back to 443 by default. Oct 30, 2024
@zuobiao-zhou
Copy link
Member

hi, this is a feature, auto config default ssl port 443.

However, when a user manually changes an HTTPS port number, clicking the "Enable HTTPS" button forces the port number back to 443. It may be better if the button only sets the default value; when the user has already modified the port, clicking "Enable HTTPS" should leave the port number unchanged.

yunfan24 added a commit to yunfan24/hertzbeat that referenced this issue Dec 23, 2024
@yunfan24
[Improve] add notification when port number changes automatically due…
993a4b9 
… to HTTPS toggle.(apache#2779)
@yunfan24 yunfan24 mentioned this issue Dec 23, 2024
Merged
4 tasks
@tomsun28 tomsun28 linked a pull request Dec 24, 2024 that will close this issue
[Improve] add notification when port number changes automatically due to HTTPS toggle.(#2779) #2896
Merged
4 tasks
tomsun28 pushed a commit that referenced this issue Dec 24, 2024
@yunfan24
[Improve] add notification when port number changes automatically due…
6a64752 
… to HTTPS toggle.(#2779) (#2896)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: volunteer wanted task
Projects
Apache HertzBeat (Incubating)
Status: Done
Milestone
No milestone
4 participants
@shenliehuozhi @tomsun28 @zqr10159 @zuobiao-zhou