Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Android) Merge old PR, apply brief mods and update for Android 13 #842

Closed
wants to merge 1 commit into from
Closed

(Android) Merge old PR, apply brief mods and update for Android 13 #842

wants to merge 1 commit into from

Conversation

zubus
Copy link

@zubus zubus commented Jul 28, 2023

Platforms affected

Android

Motivation and Context

Based on jalios@bd1dd6a and dongourdet@fa95703

#679
#660
#656
#825
#611
#783
Closes #679
Closes #660
Closes #679

Description

This Pull Request updates the previous implementation which aimed to catch RecoverableSecurityException and request permission to delete media from the Media Store. These updates ensure compatibility with the current codebase of the plugin.

In addition to revising the previous implementation, brief modifications were made to extend support for Android 13. These changes have been tested to confirm they are working as expected.

This update aligns the plugin with Android's latest standards, improving its overall reliability and usability across different Android versions.
Please, let me know if any changes or additional information are required as we move forward with this Pull Request.

Testing

Motorola with Android 10

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • [x ] Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • [x ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@EYALIN
Copy link

EYALIN commented Aug 17, 2023

@zubus thank you for your help.
it is not compiling because "getimage" is being called with 3 parameters in 2 places instead 2. can you fix it, please?

@Nikilu
Copy link

Nikilu commented Sep 25, 2023

Hi All,
When it is expected to merge? Because our app is depended on this merge request so that we can fix the Camera issue for Error code '20'. Unfortunately we cannot use the fork because of some internal policy hence we need the master version.

@erisu
Copy link
Member

erisu commented Sep 25, 2023 •
edited
Loading

I am not sure if this PR is valid anymore compared with the current release but they should:

  1. Rebase the PR. There are conflicts and appears that all of these changes already exist in the current release in some form.
  2. Update the description and title to explain exactly what the changes are remaining after the rebase and what it is resolving.

@erisu
Copy link
Member

erisu commented Sep 25, 2023 •
edited
Loading

I would also suggest submitting each fix as its own PR. IMO usually a massive PR that fixes many things are ignored.

The current description and title sounds like a collection of changes for various things.

@breautek
Copy link
Contributor

Closing as obsolete, #907 removes the code that requires RecoverySecurityException handling.

Several other PRs landed that better improved support for scoped storage.

@breautek breautek closed this Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@zubus @EYALIN @Nikilu @erisu @breautek