CAMEL-14385: add a camel-cron component #3474
Conversation
| rootLogger.level = INFO | ||
| rootLogger.appenderRef.file.ref = file | ||
|
|
||
| #rootLogger.appenderRef.stdout.ref = stdout |
There was a problem hiding this comment.
We can remove those I believe
|
Thanks @oscerd, I"ve checked the spring-boot starter with dev profile and it seems to work. I guess it cannot be currently merged, right? |
Yeah, we"ll need to create the starters once we release 3.1.0, but it"s already a good start :-) |
|
|
||
| The following standard Camel components support the Cron endpoints: | ||
|
|
||
| - Quartz |
There was a problem hiding this comment.
camel-spring also has some cron support via spring as they have cron built-in, so we could also add this there too
| /** | ||
| * Lazy creation of the CamelCronService | ||
| */ | ||
| public synchronized void initCamelCronService() { |
There was a problem hiding this comment.
I am not a fan of this, cant we move this to doStart so its initialized there?
| | Name | Description | Default | Type | ||
| | *cronService* (advanced) | The id of the CamelCronService to use when multiple implementations are provided | | String | ||
| | *basicPropertyBinding* (advanced) | Whether the component should use basic property binding (Camel 2.x) or the newer property binding with additional capabilities | false | boolean | ||
| | *lazyStartProducer* (producer) | Whether the producer should be started lazy (on the first message). By starting lazy you can use this to allow CamelContext and routes to startup in situations where a producer may otherwise fail during starting and cause the route to fail being started. By deferring this startup to be lazy then the startup failure can be handled during routing messages via Camel's routing error handlers. Beware that when the first message is processed then creating and starting the producer may take a little time and prolong the total processing time of the processing. | false | boolean |
There was a problem hiding this comment.
Ah okay spotted this, we should fix so this option is not shown for components that are consumer only. Will fix this in camel itself.
|
|
||
| <!-- requires camel-core --> | ||
| <dependency> | ||
| <groupId>org.apache.camel</groupId> |
There was a problem hiding this comment.
What makes it require camel-core, we should ideally only depend on camel-support
|
|
||
| @Override | ||
| public Consumer createConsumer(Processor processor) throws Exception { | ||
| return delegate.createConsumer(processor); |
There was a problem hiding this comment.
You need also to do
configureConsumer(consumer)
| } | ||
|
|
||
| @Override | ||
| public void setSynchronous(boolean synchronous) { |
There was a problem hiding this comment.
Ah yeah we may need to do this on other delegate endpoints (create a jira ticket)
| return service; | ||
| } | ||
|
|
||
| // Fallback to service loader |
There was a problem hiding this comment.
In Camel we have FactoryFinder as our way of loading these kind of stuff. It made it work in OSGi too. However maybe service loader is okay in these modern cloud days.
| String uri = uriPath + "?" + query; | ||
|
|
||
| QuartzComponent quartz = context.getComponent("quartz", QuartzComponent.class); | ||
| return quartz.createEndpoint(uri); |
There was a problem hiding this comment.
Wonder if after we get https://issues.apache.org/jira/browse/CAMEL-14389 done we should start using the type-safe dsl for scenario like this one as it would ease refactoring/deprecations
| * The Camel cron component. | ||
| */ | ||
| @Component("cron") | ||
| public class CronComponent extends DefaultComponent { |
There was a problem hiding this comment.
Maybe we should implement DelegateEndpoint
There was a problem hiding this comment.
You mean.. providing kinda DelegateEndpointSupport?
nicolaferraro
force-pushed
the
CAMEL-14385-camel-cron
branch
from
e4e7ce0 to
987c45c
Compare
|
Thanks for the hints. I shoud have fixed the code. I"ve added another implementation in camel-spring, so that it can be used in Spring or Spring-boot oob without pulling quartz. I"ve switched to FactoryFinder as well. |
Fix CAMEL-14385
Refs: apache/camel-k-runtime#223