AVRO-3680: [Python] allow to disable name validation #1995
Conversation
|
N.B. One of the build failures is due to https://issues.apache.org/jira/browse/AVRO-3681 |
For interoperability the Python parsing API allows disabling the name validation. It is possible to create schema with names having e.g. dashes from Java SDK. The Python name validation is stricter and follows the Avro specification.
jjaakola-aiven
force-pushed
the
AVRO-3680-python-allow-disabling-name-validation
branch
from
07de050
to
f1aa540
Compare
|
If the python validation is stricter, is the bug not with Java SDK? (which should be more strict to prevent creating such names) It seems the |
|
@NotoriousPyro I do also feel that Java is too lenient and should follow the spec. The actual issue is that there are existing schemas in the wild with names that are not compliant. So the workaround to disable name validation is needed. For new data I think the validation should be enabled, also on Java SDK. |
|
@NotoriousPyro There is a current discussion on the mailing list noted in the JIRA -- the issue is that some systems rely on the "tolerance" that has existed for non-compliant names in the Java SDK. To guarantee interoperability today, the validate_names option should definitely be set to |
For interoperability the Python parsing API allows disabling the name validation. It is possible to create schema with names having e.g. dashes from Java SDK. The Python name validation is stricter and follows the Avro specification.
Contribution Checklist
What is the purpose of the change
https://issues.apache.org/jira/browse/AVRO-3680
For interoperability the Python parsing API allows disabling the name validation. It is possible to create schema with names having e.g. dashes from Java SDK. The Python name validation is stricter and follows the Avro specification.
Verifying this change
This change added tests and can be verified as follows:
NameandNamesto/lang/py/avro/test/test_name.py.validate_namesflag set to false.Documentation