Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: plugin metadata add id value for etcd checker #11452

Merged
merged 1 commit into from
Aug 1, 2024
Merged

fix: plugin metadata add id value for etcd checker #11452

merged 1 commit into from
Aug 1, 2024

Conversation

ronething
Copy link
Contributor

@ronething ronething commented Jul 31, 2024 •
edited
Loading

Description

Fixes #11216

fix part 1 of this issue by adding an id field to the plugin metadata with the value of the plugin name

This PR is a partial fork of #11430.

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@moonming moonming merged commit d0af27b into apache:master Aug 1, 2024
35 checks passed
@ronething ronething deleted the fix/plugin_metadata_admin branch August 1, 2024 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nic-6443 nic-6443 nic-6443 approved these changes

@moonming moonming moonming approved these changes

@AlinsRan AlinsRan AlinsRan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: the plugin metadata obtained from etcd has not been validated by schema
4 participants
@ronething @nic-6443 @moonming @AlinsRan